Modify the challenge overview page #142

Sanji515 · 2019-06-10T11:35:11Z

Changes proposed in this pull request:

Changed some of the minor styling from the current version like border-radius of the card from 4px to 10px and similar other things also
Link to live demo: http://pr-142-evalai.surge.sh

Note: Edit challenge description is not in this PR, will open another PR for that

Screenshot:

Changed some of the minor styling from the current version Note: Edit description feature is not in this PR.

This PR is an extension of PR(Cloud-CV#142). Added feature to edit the challenge description using the `froala editor`.

Sanji515 · 2019-06-12T13:44:18Z

@RishabhJain2018 @galipremsagar @Shekharrajak @lunayach

Please review

src/app/components/challenge/challengeoverview/challengeoverview.component.ts

lunayach · 2019-06-12T14:20:27Z

@Sanji515 I didn't see unit tests with this PR. Do you plan to add them? (Also, I see the current build failing.)

Sanji515 · 2019-06-12T14:23:55Z

@lunayach well I'm thinking to open new PR for the tests, is there anything wrong in it?

lunayach · 2019-06-12T14:28:52Z

@Sanji515 It's okay, but ideally, each PR should be accompanied with the corresponding unit tests added for the added/modified code. Isn't that the purpose of unit tests? Checking (though only to some extent) working of the added code.

- Modified the challenge evaluation page and added the feature to edit the text and evaluation script file. - This is an extension of PR (Cloud-CV#142 & Cloud-CV#144)

…for the challenge container

…pec file

codecov-io · 2019-06-21T09:55:05Z

Codecov Report

Merging #142 into master will decrease coverage by 1%.
The diff coverage is 31.93%.

@@            Coverage Diff             @@
##           master     #142      +/-   ##
==========================================
- Coverage   54.22%   53.22%   -1.01%     
==========================================
  Files          55       55              
  Lines        2353     2463     +110     
  Branches      253      261       +8     
==========================================
+ Hits         1276     1311      +35     
- Misses       1002     1077      +75     
  Partials       75       75

Impacted Files	Coverage Δ
...lengesubmissions/challengesubmissions.component.ts	`35.55% <0%> (ø)`	⬆️
src/app/components/profile/profile.component.ts	`51.25% <0%> (ø)`	⬆️
...ponents/publiclists/teamlist/teamlist.component.ts	`35.22% <0%> (ø)`	⬆️
...rc/app/components/utility/input/input.component.ts	`59.49% <100%> (+0.51%)`	⬆️
...rc/app/components/challenge/challenge.component.ts	`41.37% <22.8%> (-36.05%)`	⬇️
...rc/app/components/utility/modal/modal.component.ts	`42.59% <38.46%> (-2.65%)`	⬇️
src/app/services/challenge.service.ts	`32.07% <38.88%> (+0.86%)`	⬆️
src/app/services/endpoints.service.ts	`65.15% <50%> (-0.98%)`	⬇️
...e/challengeoverview/challengeoverview.component.ts	`65.51% <50%> (-34.49%)`	⬇️

Impacted Files	Coverage Δ
...lengesubmissions/challengesubmissions.component.ts	`35.55% <0%> (ø)`	⬆️
src/app/components/profile/profile.component.ts	`51.25% <0%> (ø)`	⬆️
...ponents/publiclists/teamlist/teamlist.component.ts	`35.22% <0%> (ø)`	⬆️
...rc/app/components/utility/input/input.component.ts	`59.49% <100%> (+0.51%)`	⬆️
...rc/app/components/challenge/challenge.component.ts	`41.37% <22.8%> (-36.05%)`	⬇️
...rc/app/components/utility/modal/modal.component.ts	`42.59% <38.46%> (-2.65%)`	⬇️
src/app/services/challenge.service.ts	`32.07% <38.88%> (+0.86%)`	⬆️
src/app/services/endpoints.service.ts	`65.15% <50%> (-0.98%)`	⬇️
...e/challengeoverview/challengeoverview.component.ts	`65.51% <50%> (-34.49%)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 965800b...d06b1db. Read the comment docs.

Sanji515 · 2019-06-21T14:04:13Z

@lunayach @Shekharrajak @galipremsagar @RishabhJain2018

Please review

src/styles/base.scss

src/app/components/challenge/challenge.component.ts

Shekharrajak

Can you try to write some testcases for your newly(you can try for the old one as well) created method otherwise later on no one will check all the UI if they are breaking any existing feature or functionality.

src/app/components/challenge/challenge.component.html

Sanji515 · 2019-06-24T05:27:08Z

Can you try to write some testcases for your newly

@Shekharrajak As other PR's dependent on each other so without merging you cannot review the functionality of other PR's, so thinking to open separate PR's for the tests as they are merged into master

Shekharrajak · 2019-06-24T05:33:27Z

Okay! You can open a WIP PR titled 'Specs of challenge overview page #142 ', because I don't want to forget it because it is common that developers write code and after new release old functionalities break, because of improper maintenance and specs.

Sanji515 · 2019-06-24T08:14:09Z

@Shekharrajak I've applied the changes, please review

Sanji515 · 2019-06-26T06:58:14Z

@Shekharrajak Please review

src/app/components/challenge/challenge.component.html

Sanji515 · 2019-06-26T14:42:26Z

Hey @Shekharrajak I've formatted the code, please review if it looks good to you

Instead of const made the apiCall a component variable so that it will be easy to write the test for the API call

Sanji515 · 2019-06-27T11:28:40Z

@Shekharrajak Please review

Sanji515 added 4 commits June 10, 2019 15:49

initial commit

94fb076

Modified the challenge overview

bcb03eb

Changed some of the minor styling from the current version Note: Edit description feature is not in this PR.

fix travis errors and remove unused lines

1fb15d7

minor changes

959c56d

Sanji515 added a commit to Sanji515/EvalAI-ngx that referenced this pull request Jun 12, 2019

Add feature to edit the challenge description

0ea5ceb

This PR is an extension of PR(Cloud-CV#142). Added feature to edit the challenge description using the `froala editor`.

Sanji515 mentioned this pull request Jun 12, 2019

Add feature to edit the challenge description #144

Merged

minor change

ef50ad4

lunayach reviewed Jun 12, 2019

View reviewed changes

src/app/components/challenge/challengeoverview/challengeoverview.component.ts Show resolved Hide resolved

Sanji515 mentioned this pull request Jun 12, 2019

Modified the challenge evaluation page #145

Merged

Sanji515 added 12 commits June 13, 2019 17:15

Merge branch 'master' into challenge-overview

454444d

resolved conflicts after updating branch with master and added media …

558457f

…for the challenge container

testing on travis after removing test-log

6c784be

testing in travis by modifying the travis.yml

ab29a1a

revert travis.yml file as master

b42b345

checking by changing privacy policy spec file

eaf7dae

removed the test case for smae title and nav text in privacy policy s…

5271bef

…pec file

removed tests for privacy policy spec

01324a3

reverted the privacy policy spec file

c30dd14

added service in the modal spec file

16f8bd8

changed the path for the servies in the spec file of modal component

06d854f

typo in modal component spec file

899ec28

lunayach reviewed Jun 23, 2019

View reviewed changes

src/styles/base.scss Show resolved Hide resolved

lunayach reviewed Jun 23, 2019

View reviewed changes

src/app/components/challenge/challenge.component.ts Outdated Show resolved Hide resolved

lunayach approved these changes Jun 23, 2019

View reviewed changes

lunayach added the can-be-merged label Jun 23, 2019

changed the console log of delete challenge and edit challenge title API

7625cef

Shekharrajak reviewed Jun 24, 2019

View reviewed changes

src/app/components/challenge/challenge.component.html Outdated Show resolved Hide resolved

src/app/components/challenge/challenge.component.html Outdated Show resolved Hide resolved

Merge branch 'master' into challenge-overview

c6f7a97

Sanji515 added 2 commits June 24, 2019 11:09

made the line length small to make it readable

a72332e

removed unnecessary comments in confirm component

5d91f03

Shekharrajak reviewed Jun 26, 2019

View reviewed changes

src/app/components/challenge/challenge.component.html Outdated Show resolved Hide resolved

formatted the challenge component html

9b516ec

Made the apiCall component variable

f97be81

Instead of const made the apiCall a component variable so that it will be easy to write the test for the API call

Shekharrajak approved these changes Jun 28, 2019

View reviewed changes

RishabhJain2018 added 2 commits July 3, 2019 16:56

Merge branch 'master' into challenge-overview

3f9ecf2

Merge branch 'master' into challenge-overview

d06b1db

RishabhJain2018 merged commit 75e8c6f into Cloud-CV:master Jul 3, 2019

snyk-bot mentioned this pull request Jan 29, 2022

[Snyk] Upgrade tslib from 1.14.1 to 2.3.1 Suryansh5545/EvalAI-ngx#17

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Modify the challenge overview page #142

Modify the challenge overview page #142

Sanji515 commented Jun 10, 2019 •

edited

Loading

Sanji515 commented Jun 12, 2019

lunayach commented Jun 12, 2019 •

edited

Loading

Sanji515 commented Jun 12, 2019 •

edited

Loading

lunayach commented Jun 12, 2019

codecov-io commented Jun 21, 2019 •

edited

Loading

Sanji515 commented Jun 21, 2019

Shekharrajak left a comment

Sanji515 commented Jun 24, 2019 •

edited

Loading

Shekharrajak commented Jun 24, 2019

Sanji515 commented Jun 24, 2019

Sanji515 commented Jun 26, 2019

Sanji515 commented Jun 26, 2019

Sanji515 commented Jun 27, 2019

Modify the challenge overview page #142

Modify the challenge overview page #142

Conversation

Sanji515 commented Jun 10, 2019 • edited Loading

Changes proposed in this pull request:

Sanji515 commented Jun 12, 2019

lunayach commented Jun 12, 2019 • edited Loading

Sanji515 commented Jun 12, 2019 • edited Loading

lunayach commented Jun 12, 2019

codecov-io commented Jun 21, 2019 • edited Loading

Codecov Report

Sanji515 commented Jun 21, 2019

Shekharrajak left a comment

Choose a reason for hiding this comment

Sanji515 commented Jun 24, 2019 • edited Loading

Shekharrajak commented Jun 24, 2019

Sanji515 commented Jun 24, 2019

Sanji515 commented Jun 26, 2019

Sanji515 commented Jun 26, 2019

Sanji515 commented Jun 27, 2019

Sanji515 commented Jun 10, 2019 •

edited

Loading

lunayach commented Jun 12, 2019 •

edited

Loading

Sanji515 commented Jun 12, 2019 •

edited

Loading

codecov-io commented Jun 21, 2019 •

edited

Loading

Sanji515 commented Jun 24, 2019 •

edited

Loading