Modified homepage #140

sanketbansal · 2019-06-06T03:55:36Z

Changes proposed in this pull request:

Modified the home component to make its UI similar to current EvalAI UI.

Link to live demo: http://pr-140-evalai.surge.sh

lunayach · 2019-06-06T04:51:46Z

@sanketbansal Could you see why the tests are failing?

sanketbansal · 2019-06-06T05:26:35Z

Working on it

codecov-io · 2019-06-08T12:58:12Z

Codecov Report

Merging #140 into master will increase coverage by 0.16%.
The diff coverage is 62.79%.

@@            Coverage Diff             @@
##           master     #140      +/-   ##
==========================================
+ Coverage   52.06%   52.23%   +0.16%     
==========================================
  Files          61       61              
  Lines        3196     3226      +30     
  Branches      371      374       +3     
==========================================
+ Hits         1664     1685      +21     
- Misses       1444     1451       +7     
- Partials       88       90       +2

Impacted Files	Coverage Δ
src/app/services/auth.service.ts	`24.05% <10%> (-0.31%)`	⬇️
src/app/services/endpoints.service.ts	`67.94% <100%> (+0.84%)`	⬆️
src/app/components/home/home.component.ts	`78.12% <77.41%> (-21.88%)`	⬇️
src/app/services/window.service.ts	`70.96% <0%> (-3.23%)`	⬇️

Impacted Files	Coverage Δ
src/app/services/auth.service.ts	`24.05% <10%> (-0.31%)`	⬇️
src/app/services/endpoints.service.ts	`67.94% <100%> (+0.84%)`	⬆️
src/app/components/home/home.component.ts	`78.12% <77.41%> (-21.88%)`	⬇️
src/app/services/window.service.ts	`70.96% <0%> (-3.23%)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8bb735a...b8da7d5. Read the comment docs.

lunayach · 2019-06-23T15:21:21Z

@sanketbansal again 137 file changes! Are all of them for this PR only?

sanketbansal · 2019-06-23T17:59:21Z

@lunayach No! it includes file changes of static styles and assets for which I have created a separate PR #154, #156, #157.
Please review those PRs first then I will rebase it.

lunayach · 2019-06-24T03:09:44Z

@sanketbansal Yes, I have already reviewed #154. Please see.

sanketbansal · 2019-07-14T14:30:50Z

@RishabhJain2018 @lunayach @Shekharrajak @galipremsagar please review

lunayach · 2019-07-15T06:16:39Z

205 file changes! Need to review/merge #154, I guess.

sanketbansal · 2019-07-19T04:15:22Z

@lunayach file changes has been reduced please review

lunayach · 2019-07-19T04:18:27Z

@sanketbansal I see, that it still has styles-port folder?

sanketbansal · 2019-07-19T04:40:24Z

Yeah I just kept it to show you the new base styles which needs to be add for the whole project as discussed. I will remove it after your review.

lunayach · 2019-07-21T10:06:37Z

After resolving #141, @sanketbansal resolve conflicts here.

src/app/components/nav/footer/footer.component.html

lunayach · 2019-07-21T15:29:43Z

@sanketbansal large no. of conflicts are for this one; please resolve them.

Ported the image assets from angularJs application into 'image-port' directory

AngularJS home page ported to Angular 7 by converting main controller logic into Home Page class logic.

Ported styles from angularjs Application inside style-port folder

Made the footer UI similar to the angularjs application one.

Made header UI similar to Angularjs Application one.

Removed test cases to evaluate title and h1 element textContent

Removed unnecessary changes from home page

console logs removed from home page

Removed script to load github stars and forks.

Logic added for host challenge button to navigate challenge-create component

Assets removed from image-port folder and moved into image foider

Image assets moved from organization folder to partners folder

Styles from module folder removed

Duplicates removed from base.scss file

Duplicates removed from main.scss file

Unused css removed from basic .scss file

Styles relevant to component added

Unused methods removed from auth service

Added basic styles for base styles

Removed loading styles from basic.scss file

mian.scss file removed from styles-port folder

Removed styles from styles-port folder

lunayach · 2019-07-21T15:56:35Z

src/app/components/home/home.component.html

+      </div>
+    </section>
+    <!-- organizatons section -->
+    <section class="ev-container ev-reverse-details text-med-black ev-super-light-bg " id="ev-scroll-down">


Keep the ID's unique. This, https://github.com/Cloud-CV/EvalAI-ngx/pull/140/files#diff-52b8edd82669758b98abb08f9c2a93b1R212, and https://github.com/Cloud-CV/EvalAI-ngx/pull/140/files#diff-52b8edd82669758b98abb08f9c2a93b1R26 have the same ID's.

lunayach · 2019-07-21T15:59:44Z

src/app/components/home/home.component.spec.ts

@@ -60,17 +60,4 @@ describe('HomeComponent', () => {
  it('should be created', () => {
    expect(component).toBeTruthy();
  });
-


I see why you have removed the test specs here. But add to TODO's to add new test cases here.

lunayach · 2019-07-21T16:01:36Z

src/app/components/home/home.component.ts

+    if (this.authService.isAuth) {
+      this.router.navigate(['/challenge-create']);
+    } else {
+      this.router.navigate(['/auth/login']);


Don't hard-code the URL's; like in previous PR's, define them as constants above.

lunayach · 2019-07-21T16:02:24Z

src/app/components/home/home.component.ts

-   */
-  ngOnInit() {}
+  init() {
+    const logInStatus = this.authService.isLoggedIn();


Where are we using logInStatus?

lunayach · 2019-07-21T16:04:55Z

src/app/services/auth.service.ts

@@ -16,8 +16,14 @@ export class AuthService {
   */
  isAuth = false;

+  /**
+   * Porting Ends


Remove this.

lunayach · 2019-07-21T16:06:41Z

src/styles/base.scss

@@ -392,6 +393,10 @@ mat-chip {
  padding: 30px 40px 40px 40px;
 }

+//.ev-md-container {


Remove this.

lunayach · 2019-07-21T16:08:27Z

src/styles/base.scss

+.btn-pagination:hover {
+  background-color: $highlight;
+  i {
+    font-size: 16px;


Suggested change

font-size: 16px;

font-size: $fs-16;

Also, above.

lunayach

Functionality works! Minor changes needed.

Removed unused methods and variables Removed commented lines.

lunayach

LGTM! @RishabhJain2018, Homepage is smooth now.

sanketbansal force-pushed the modified-homepage branch from 7e153a0 to eab5037 Compare June 8, 2019 12:52

sanketbansal mentioned this pull request Jun 25, 2019

Modified styles and assets #154

Merged

sanketbansal force-pushed the modified-homepage branch from 352eb80 to 87f6a81 Compare July 17, 2019 05:53

sanketbansal mentioned this pull request Jul 17, 2019

Fixed test cases issue #157

Closed

sanketbansal force-pushed the modified-homepage branch 3 times, most recently from bc51121 to 5b73a7e Compare July 19, 2019 04:11

lunayach mentioned this pull request Jul 21, 2019

Modified dashboard page #141

Merged

sanketbansal force-pushed the modified-homepage branch from 9d050ba to 3830bac Compare July 21, 2019 14:43

lunayach reviewed Jul 21, 2019

View reviewed changes

src/app/components/nav/footer/footer.component.html Outdated Show resolved Hide resolved

sanketbansal added 7 commits July 21, 2019 11:33

Ported image assets

51e4f84

Ported the image assets from angularJs application into 'image-port' directory

Ported Home Page

a45e1ff

AngularJS home page ported to Angular 7 by converting main controller logic into Home Page class logic.

Added styles from angularjs

fb62dd3

Ported styles from angularjs Application inside style-port folder

Modified footer

d9fa19b

Made the footer UI similar to the angularjs application one.

Modified static header

5971590

Made header UI similar to Angularjs Application one.

Changes in home component test file

0a97f5c

Removed test cases to evaluate title and h1 element textContent

Removed unnecessary changes

06c3d79

Removed unnecessary changes from home page

sanketbansal added 15 commits July 21, 2019 11:39

Removed logs

f2d5116

console logs removed from home page

Modified footer component

a2a6421

Removed script to load github stars and forks.

Added logic for host challenge

60c228b

Logic added for host challenge button to navigate challenge-create component

removed image-port folder

adb6f02

Assets removed from image-port folder and moved into image foider

Moved organization images

6b1f8c9

Image assets moved from organization folder to partners folder

Removed styles from styles-port folder

e59de69

Styles from module folder removed

Removed duplicates from base.scss

fe04614

Duplicates removed from base.scss file

Removed unused css from main.scss

496e1a4

Duplicates removed from main.scss file

Removed unused css from basic.scss

f6c5114

Unused css removed from basic .scss file

Added component specific styles

4eb0912

Styles relevant to component added

Remoed unused methods

792279c

Unused methods removed from auth service

Dependency Changes

6d195ac

Added basic styles for base styles

Removed loading styles

1386ec4

Removed loading styles from basic.scss file

Removed main.scss file

d040a6d

mian.scss file removed from styles-port folder

Removed styles-port folder

c845bbf

Removed styles from styles-port folder

sanketbansal force-pushed the modified-homepage branch from 3830bac to c845bbf Compare July 21, 2019 15:42

lunayach reviewed Jul 21, 2019

View reviewed changes

sanketbansal force-pushed the modified-homepage branch 2 times, most recently from ccd8c3f to b43c7a9 Compare July 21, 2019 17:04

Changes in home page

b8da7d5

Removed unused methods and variables Removed commented lines.

sanketbansal force-pushed the modified-homepage branch from b43c7a9 to b8da7d5 Compare July 21, 2019 18:44

lunayach approved these changes Jul 21, 2019

View reviewed changes

RishabhJain2018 merged commit c03b0cb into Cloud-CV:master Jul 21, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Modified homepage #140

Modified homepage #140

sanketbansal commented Jun 6, 2019 •

edited

Loading

lunayach commented Jun 6, 2019

sanketbansal commented Jun 6, 2019

codecov-io commented Jun 8, 2019 •

edited

Loading

lunayach commented Jun 23, 2019

sanketbansal commented Jun 23, 2019

lunayach commented Jun 24, 2019

sanketbansal commented Jul 14, 2019

lunayach commented Jul 15, 2019

sanketbansal commented Jul 19, 2019

lunayach commented Jul 19, 2019

sanketbansal commented Jul 19, 2019

lunayach commented Jul 21, 2019

lunayach commented Jul 21, 2019

lunayach Jul 21, 2019

sanketbansal Jul 21, 2019

lunayach Jul 21, 2019

sanketbansal Jul 21, 2019

lunayach Jul 21, 2019

sanketbansal Jul 21, 2019

lunayach Jul 21, 2019

sanketbansal Jul 21, 2019

lunayach Jul 21, 2019

sanketbansal Jul 21, 2019

lunayach Jul 21, 2019

sanketbansal Jul 21, 2019

lunayach Jul 21, 2019

sanketbansal Jul 21, 2019

lunayach left a comment

lunayach left a comment

Modified homepage #140

Modified homepage #140

Conversation

sanketbansal commented Jun 6, 2019 • edited Loading

Changes proposed in this pull request:

lunayach commented Jun 6, 2019

sanketbansal commented Jun 6, 2019

codecov-io commented Jun 8, 2019 • edited Loading

Codecov Report

lunayach commented Jun 23, 2019

sanketbansal commented Jun 23, 2019

lunayach commented Jun 24, 2019

sanketbansal commented Jul 14, 2019

lunayach commented Jul 15, 2019

sanketbansal commented Jul 19, 2019

lunayach commented Jul 19, 2019

sanketbansal commented Jul 19, 2019

lunayach commented Jul 21, 2019

lunayach commented Jul 21, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lunayach left a comment

Choose a reason for hiding this comment

lunayach left a comment

Choose a reason for hiding this comment

sanketbansal commented Jun 6, 2019 •

edited

Loading

codecov-io commented Jun 8, 2019 •

edited

Loading