This repository has been archived by the owner on Jul 6, 2020. It is now read-only.
Modified the home page #138
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Project has been upgraded to latest angular-cli version. Required config files has been updated according to the latest version. Angular version related bug present in api.service.ts has been removed.
Typescript version changed to <3.3.0 to meet the requirement of @angular/compiler-cli.
Downgraded the protractor version to "~5.1.2".
Downgraded the @angular/compiler-cli version to ^5.2.0.
Added includePaths property for stylePreprocessorOptions in angular.json . Now , ng test command executes successfully.
A new line has been added at the end of tsconfig.json file.
Typescript version changed from <3.3.0 to ~3.2.0
Updated angular dependencies to version 7 along with peer dependencies.
Changes made in contact-component to resolve testing issue
Added some rxjs changes to resolve testing issue
Testing routes are added for challenge-create component to resolve teams/hosts error .
Routes are added in the test suites to resolve 'cannot find teams/hosts' issue
Routes are added in the test suite to resolve 'cannot find url participate' issue
Routes are added in the test suite to resolve 'cannot find url auth/login' issue
Added trailing white space in app.component.ts file
Removed console log lines from challenge submit component
Removed '/' to provide proper assets path
Ported the image assets from angularJs application into 'image-port' directory
AngularJS home page ported to Angular 7 by converting main controller logic into Home Page class logic.
Ported styles from angularjs Application inside style-port folder
Fonts and font-awesome files are copied into the fonts folder
Modified fonts.scss file to include fonts copied from angularjs application
Made the footer UI similar to the angularjs application one.
Made header UI similar to Angularjs Application one.
Removed test cases to evaluate title and h1 element textContent
Removed unnecessary changes from home page
Added isAuth parameter in auth service
Changed the test to vefiy the text content of the h3 tag in home component
Removed fake activated routes to work with routerLink property in <a> tag
Added mock window service for calling loadJS method.
Added routerLink proprety for routing through UI
Added github fork and star button using github api
Changes made in auth services to integrate angularJS authentication features
Changes made in static header to handle different authentication cases
Modified home page to handle authentication
Routing to 'auth/login' has been removed
console logs removed from home page
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request: