Modified get involved page to the current version of EvalAI

[Sanji515]

Minor changes related to css

• Changed the link color from red to yellow and some font related css to match with the theme of current version

• Link to live demo: http://pr-136-evalai.surge.sh

Old UI Screenshot 1:

Modified UI Screenshot 1:

Modified UI Screenshot 2:

[codecov-io]

Codecov Report

Merging #136 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           master    #136      +/-   ##
=========================================
- Coverage   53.22%   53.2%   -0.02%     
=========================================
  Files          55      55              
  Lines        2463    2462       -1     
  Branches      261     261              
=========================================
- Hits         1311    1310       -1     
  Misses       1077    1077              
  Partials       75      75

Impacted Files	Coverage Δ
.../components/get-involved/get-involved.component.ts	100% <100%> (ø)	⬆️

Impacted Files	Coverage Δ
.../components/get-involved/get-involved.component.ts	100% <100%> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 75e8c6f...d125007. Read the comment docs.

[Shekharrajak]

I don't see much difference. Can you let us know what are the changes you did in current version of EvalAI? Make sure you write your changes in PR description properly.

[lunayach]

Hi, @Sanji515 could you respond to @Shekharrajak and add some tests before we merge this?

[Sanji515]

Make sure you write your changes in PR description properly

@Shekharrajak @lunayach Updated the PR description, please have a look

[Sanji515]

add some tests before we merge this

done, @lunayach please review

[Sanji515]

@lunayach @Shekharrajak please review

[lunayach]

Very minor things, but better if we don't leave them for the last moment.

UL list having "Get Involved", "CloudCV Website" etc. seems misaligned. (IMO)

Should we have a border separating the paragraph above and "Report issues"? Also little too much whitespaces around the centred text. (IMO)

[lunayach]

Merging #136 into master will decrease coverage by 0.01%.

@Sanji515 if merging the code does not increase the code-coverage, we should make sure that the coverage is not decreased at least.

[Sanji515]

@lunayach I think that's the only test case can be written for this static page, please let me know me if I'm missing something

[lunayach]

Okay, @Sanji515. It's fine for this PR, but please take a note of it for future PR's.

[Sanji515]

@lunayach yeah I do check report but even after adding that one test the report hasn't updated, it's still the same.

[Sanji515]

UL list having "Get Involved", "CloudCV Website" etc. seems misaligned

@lunayach hey I think footer is going to be change a/c to our current version, so there's no need to do that

Should we have a border separating the paragraph above and "Report issues"? Also little too much whitespaces around the centred text

done and updated the PR description, please review

[Sanji515]

@lunayach please review

[Sanji515]

@lunayach can you please take a look at this?

[lunayach]

HI @Sanji515, by the border in the above comment, I meant horizontal line separating the section beginning with "Report issues" and the introductory text above it. I guess, you may have misunderstood and underlined all the headings like "Report issues", "Press" instead. Those may not be required and could be removed. (IMO)

[Sanji515]

@lunayach sorry that I misunderstood the things, I've removed the border bottom of headings and added a border above the first heading and below the intro text

Please review

[lunayach]

Looks good to me. LGTM.