Modified contact us page to the current version of EvalAI #133
Conversation
Codecov Report
@@ Coverage Diff @@
## master #133 +/- ##
==========================================
- Coverage 53.41% 53.38% -0.04%
==========================================
Files 55 55
Lines 2355 2347 -8
Branches 252 253 +1
==========================================
- Hits 1258 1253 -5
+ Misses 1024 1020 -4
- Partials 73 74 +1
Continue to review full report at Codecov.
|
|
@Sanji515 Please resolve the conflicts here. |
@RishabhJain2018 done |
|
@RishabhJain2018 @galipremsagar @lunayach @Shekharrajak Please review |
| </div> | ||
|
|
||
| <div *ngIf="type=='textarea'"> | ||
| <textarea autosize class="input-field" (input)="validateInput($event.target.value)" [class.isValid]="isValid" [class.theme-dark]="theme=='dark'" [value]="value" [readonly]="isReadonly"></textarea> |
There was a problem hiding this comment.
Please try to do this without adding new package. If it is required in multiple places or needed for other features which is not present in Angular then it is fine but for small improvement adding new package is not a good idea.
There was a problem hiding this comment.
@Shekharrajak I used this package thinking that it would be good if we have 'text-area' in other places in the future.
There was a problem hiding this comment.
Cool! Using more packages can slow down the website. Can you check whether it is behaving properly in all the device size or not?
There was a problem hiding this comment.
@Shekharrajak yeah it's working perfectly, please check if it's working on your side too
| <span class="input-bar"></span> | ||
| <label [class.is-not-empty]="!isEmpty" [class.theme-dark]="theme=='dark'">{{placeholder}}</label> | ||
| <i class="input-icon {{icon}}" *ngIf="isIconPresent"></i> | ||
| <div class="input-message" #textValue [class.hidden]="!(((isRequired && isEmpty)||(!isValid && !isEmpty)) && isDirty)">{{message}}</div> |
There was a problem hiding this comment.
conditions like !(((isRequired && isEmpty)||(!isValid && !isEmpty)) && isDirty) is not looking good and readable. You can create a separate method to check it- which will return True/False.
|
@Shekharrajak Please review |
There was a problem hiding this comment.
- Whenever you add new method or variables, try add some documentation for it for future reference.
- Always try to add testcases for your changes as many as possible.
For now we can merge it since you need to make changes top of this PR. But I will expect above things in other PRs.
|
Also please write better commit messages from next time -- 'suggested changes' doesn't tell anything about commit. |
* modified contact us page * minor change * minor responsive change
* modified contact us page * minor change * minor responsive change
* modified contact us page * minor change * minor responsive change
* modified contact us page * minor change * minor responsive change
For the right side icon of all input, changed to use
font-awesome iconinstead of having image for all of them, so for all other input icons like inLogin or Signupwe'll change that in coming PR'sIn the html of
Input Component, added the input for textareaUsed package
ngx-textarea-autosizefor dynamically changing the height of textarea when input length growsLink to live demo: http://pr-133-evalai.surge.sh
Here's the screenshot: