Skip to content
This repository has been archived by the owner on Jul 6, 2020. It is now read-only.

Setup: Fix docker configuration to set up evalai-ngx in dev environment #129

Merged
merged 5 commits into from
May 13, 2019

Conversation

RishabhJain2018
Copy link
Member

@RishabhJain2018 RishabhJain2018 commented May 12, 2019

The project should be set up by simply cloning the repository and running the follwing command in the project folder.
docker-compose up

@RishabhJain2018
Copy link
Member Author

@lunayach @Shekharrajak Can you please review and test this on your local machine?

@RishabhJain2018 RishabhJain2018 added the needs review This pull request is ready for a review label May 12, 2019
@codecov-io
Copy link

codecov-io commented May 12, 2019

Codecov Report

Merging #129 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #129   +/-   ##
=======================================
  Coverage   53.43%   53.43%           
=======================================
  Files          55       55           
  Lines        2360     2360           
  Branches      253      253           
=======================================
  Hits         1261     1261           
  Misses       1025     1025           
  Partials       74       74

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d3a7e1a...dc444d4. Read the comment docs.

Copy link
Member

@Shekharrajak Shekharrajak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe other than Angularjs dockerfile, other files are updated as EvalAi/docker.

I think in near future we should have separate backend repository and in this project dockerfile we will clone and run.

docker/dev/angularjs/Dockerfile Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@RishabhJain2018
Copy link
Member Author

I believe other than Angularjs dockerfile, other files are updated as EvalAi/docker

Yeah, almost.

I think in near future we should have separate backend repository and in this project dockerfile we will clone and run

We will probably have this codebase there once it is ready to be launched in the form of submodule.

@RishabhJain2018
Copy link
Member Author

@lunayach Can you please pull this PR on your local and test?

@lunayach
Copy link
Member

Hi @RishabhJain2018, tested it locally. It's working 👍

@RishabhJain2018
Copy link
Member Author

Awesome! Thanks for testing. Merging this.

@RishabhJain2018 RishabhJain2018 changed the title Fix docker setup for setting up evalai-ngx in dev environment Setup: Fix docker configuration to set up evalai-ngx in dev environment May 13, 2019
@RishabhJain2018 RishabhJain2018 merged commit f9f802b into master May 13, 2019
@RishabhJain2018 RishabhJain2018 deleted the fix-docker-setup branch May 13, 2019 05:17
sanketbansal pushed a commit to sanketbansal/EvalAI-ngx that referenced this pull request May 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs review This pull request is ready for a review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants