Fix incorrect precision and scale from DatabaseMetaData.getColumns by zhicwu · Pull Request #815 · ClickHouse/clickhouse-java

zhicwu · 2022-01-18T15:28:19Z

merge Fix wrong precision #808 to fix wrong precision
return scale for number, date, and date time
ClickHouseDataType.Enum is deprecated and it will be removed in 0.3.3 - it's just an alias of Enum8
support binary string with ~10% performance penalty
bump vesion to 0.3.2-patch3

github-actions · 2022-01-18T15:45:26Z

Benchmark                                 (client)  (connection)  (statement)  (type)   Mode  Cnt     Score     Error  Units
Basic.insertOneRandomNumber  clickhouse-http-jdbc1         reuse       normal  object  thrpt   20   193.678 ±  29.140  ops/s
Basic.insertOneRandomNumber  clickhouse-http-jdbc1         reuse     prepared  object  thrpt   20   192.636 ±  26.494  ops/s
Basic.insertOneRandomNumber  clickhouse-http-jdbc1           new       normal  object  thrpt   20   183.383 ±  28.377  ops/s
Basic.insertOneRandomNumber  clickhouse-http-jdbc1           new     prepared  object  thrpt   20   181.711 ±  23.816  ops/s
Basic.insertOneRandomNumber   clickhouse-grpc-jdbc         reuse       normal  object  thrpt   20   198.096 ±  20.418  ops/s
Basic.insertOneRandomNumber   clickhouse-grpc-jdbc         reuse     prepared  object  thrpt   20   203.571 ±  23.534  ops/s
Basic.insertOneRandomNumber   clickhouse-grpc-jdbc           new       normal  object  thrpt   20   203.532 ±  21.148  ops/s
Basic.insertOneRandomNumber   clickhouse-grpc-jdbc           new     prepared  object  thrpt   20   202.949 ±  24.315  ops/s
Basic.selectOneRandomNumber  clickhouse-http-jdbc1         reuse       normal  object  thrpt   20  1288.791 ±  92.188  ops/s
Basic.selectOneRandomNumber  clickhouse-http-jdbc1         reuse     prepared  object  thrpt   20  1337.729 ± 103.986  ops/s
Basic.selectOneRandomNumber  clickhouse-http-jdbc1           new       normal  object  thrpt   20  1359.161 ±  84.250  ops/s
Basic.selectOneRandomNumber  clickhouse-http-jdbc1           new     prepared  object  thrpt   20  1355.471 ±  95.851  ops/s
Basic.selectOneRandomNumber   clickhouse-grpc-jdbc         reuse       normal  object  thrpt   20   753.666 ±  75.324  ops/s
Basic.selectOneRandomNumber   clickhouse-grpc-jdbc         reuse     prepared  object  thrpt   20   784.465 ±  63.581  ops/s
Basic.selectOneRandomNumber   clickhouse-grpc-jdbc           new       normal  object  thrpt   20   740.237 ±  70.331  ops/s
Basic.selectOneRandomNumber   clickhouse-grpc-jdbc           new     prepared  object  thrpt   20   812.281 ±  71.306  ops/s

github-actions · 2022-01-18T16:01:40Z

Benchmark                                 (client)  (connection)  (statement)  (type)   Mode  Cnt     Score     Error  Units
Basic.insertOneRandomNumber  clickhouse-http-jdbc1         reuse       normal  object  thrpt   20   245.745 ±  29.659  ops/s
Basic.insertOneRandomNumber  clickhouse-http-jdbc1         reuse     prepared  object  thrpt   20   240.475 ±  27.893  ops/s
Basic.insertOneRandomNumber  clickhouse-http-jdbc1           new       normal  object  thrpt   20   234.044 ±  26.394  ops/s
Basic.insertOneRandomNumber  clickhouse-http-jdbc1           new     prepared  object  thrpt   20   236.712 ±  27.225  ops/s
Basic.insertOneRandomNumber   clickhouse-grpc-jdbc         reuse       normal  object  thrpt   20   249.089 ±  27.388  ops/s
Basic.insertOneRandomNumber   clickhouse-grpc-jdbc         reuse     prepared  object  thrpt   20   245.005 ±  30.778  ops/s
Basic.insertOneRandomNumber   clickhouse-grpc-jdbc           new       normal  object  thrpt   20   245.756 ±  31.402  ops/s
Basic.insertOneRandomNumber   clickhouse-grpc-jdbc           new     prepared  object  thrpt   20   248.149 ±  29.636  ops/s
Basic.selectOneRandomNumber  clickhouse-http-jdbc1         reuse       normal  object  thrpt   20  1733.389 ±  76.214  ops/s
Basic.selectOneRandomNumber  clickhouse-http-jdbc1         reuse     prepared  object  thrpt   20  1724.890 ± 108.096  ops/s
Basic.selectOneRandomNumber  clickhouse-http-jdbc1           new       normal  object  thrpt   20  1720.489 ±  71.368  ops/s
Basic.selectOneRandomNumber  clickhouse-http-jdbc1           new     prepared  object  thrpt   20  1670.559 ±  83.886  ops/s
Basic.selectOneRandomNumber   clickhouse-grpc-jdbc         reuse       normal  object  thrpt   20  1039.308 ± 102.320  ops/s
Basic.selectOneRandomNumber   clickhouse-grpc-jdbc         reuse     prepared  object  thrpt   20  1071.315 ±  78.335  ops/s
Basic.selectOneRandomNumber   clickhouse-grpc-jdbc           new       normal  object  thrpt   20  1051.669 ± 108.308  ops/s
Basic.selectOneRandomNumber   clickhouse-grpc-jdbc           new     prepared  object  thrpt   20  1065.422 ±  95.614  ops/s

…ter binary string support

github-actions · 2022-01-24T00:17:30Z

Benchmark                                 (client)  (connection)  (statement)  (type)   Mode  Cnt     Score    Error  Units
Basic.insertOneRandomNumber  clickhouse-http-jdbc1         reuse       normal  object  thrpt   20   217.135 ± 24.882  ops/s
Basic.insertOneRandomNumber  clickhouse-http-jdbc1         reuse     prepared  object  thrpt   20   214.405 ± 23.925  ops/s
Basic.insertOneRandomNumber  clickhouse-http-jdbc1           new       normal  object  thrpt   20   211.479 ± 24.566  ops/s
Basic.insertOneRandomNumber  clickhouse-http-jdbc1           new     prepared  object  thrpt   20   211.611 ± 24.408  ops/s
Basic.insertOneRandomNumber   clickhouse-grpc-jdbc         reuse       normal  object  thrpt   20   221.481 ± 26.230  ops/s
Basic.insertOneRandomNumber   clickhouse-grpc-jdbc         reuse     prepared  object  thrpt   20   221.004 ± 23.488  ops/s
Basic.insertOneRandomNumber   clickhouse-grpc-jdbc           new       normal  object  thrpt   20   219.897 ± 27.486  ops/s
Basic.insertOneRandomNumber   clickhouse-grpc-jdbc           new     prepared  object  thrpt   20   220.436 ± 24.626  ops/s
Basic.selectOneRandomNumber  clickhouse-http-jdbc1         reuse       normal  object  thrpt   20  1138.247 ± 76.268  ops/s
Basic.selectOneRandomNumber  clickhouse-http-jdbc1         reuse     prepared  object  thrpt   20  1163.688 ± 76.778  ops/s
Basic.selectOneRandomNumber  clickhouse-http-jdbc1           new       normal  object  thrpt   20  1154.751 ± 72.665  ops/s
Basic.selectOneRandomNumber  clickhouse-http-jdbc1           new     prepared  object  thrpt   20  1161.451 ± 71.412  ops/s
Basic.selectOneRandomNumber   clickhouse-grpc-jdbc         reuse       normal  object  thrpt   20   767.945 ± 67.073  ops/s
Basic.selectOneRandomNumber   clickhouse-grpc-jdbc         reuse     prepared  object  thrpt   20   722.231 ± 68.789  ops/s
Basic.selectOneRandomNumber   clickhouse-grpc-jdbc           new       normal  object  thrpt   20   692.601 ± 73.922  ops/s
Basic.selectOneRandomNumber   clickhouse-grpc-jdbc           new     prepared  object  thrpt   20   744.940 ± 72.053  ops/s

github-actions · 2022-01-24T15:32:53Z

Benchmark                                 (client)  (connection)  (statement)  (type)   Mode  Cnt     Score    Error  Units
Basic.insertOneRandomNumber  clickhouse-http-jdbc1         reuse       normal  object  thrpt   20   202.264 ± 26.945  ops/s
Basic.insertOneRandomNumber  clickhouse-http-jdbc1         reuse     prepared  object  thrpt   20   204.332 ± 23.302  ops/s
Basic.insertOneRandomNumber  clickhouse-http-jdbc1           new       normal  object  thrpt   20   202.734 ± 25.405  ops/s
Basic.insertOneRandomNumber  clickhouse-http-jdbc1           new     prepared  object  thrpt   20   199.963 ± 19.288  ops/s
Basic.insertOneRandomNumber   clickhouse-grpc-jdbc         reuse       normal  object  thrpt   20   213.427 ± 22.393  ops/s
Basic.insertOneRandomNumber   clickhouse-grpc-jdbc         reuse     prepared  object  thrpt   20   214.013 ± 25.676  ops/s
Basic.insertOneRandomNumber   clickhouse-grpc-jdbc           new       normal  object  thrpt   20   214.345 ± 21.810  ops/s
Basic.insertOneRandomNumber   clickhouse-grpc-jdbc           new     prepared  object  thrpt   20   213.697 ± 22.001  ops/s
Basic.selectOneRandomNumber  clickhouse-http-jdbc1         reuse       normal  object  thrpt   20   977.250 ± 91.997  ops/s
Basic.selectOneRandomNumber  clickhouse-http-jdbc1         reuse     prepared  object  thrpt   20  1065.860 ± 92.370  ops/s
Basic.selectOneRandomNumber  clickhouse-http-jdbc1           new       normal  object  thrpt   20  1057.310 ± 74.606  ops/s
Basic.selectOneRandomNumber  clickhouse-http-jdbc1           new     prepared  object  thrpt   20  1085.863 ± 65.352  ops/s
Basic.selectOneRandomNumber   clickhouse-grpc-jdbc         reuse       normal  object  thrpt   20   653.939 ± 63.630  ops/s
Basic.selectOneRandomNumber   clickhouse-grpc-jdbc         reuse     prepared  object  thrpt   20   666.009 ± 60.259  ops/s
Basic.selectOneRandomNumber   clickhouse-grpc-jdbc           new       normal  object  thrpt   20   640.981 ± 62.987  ops/s
Basic.selectOneRandomNumber   clickhouse-grpc-jdbc           new     prepared  object  thrpt   20   677.950 ± 61.554  ops/s

tangjiangling · 2022-01-25T04:27:01Z

@zhicwu Do you mind if i merge all the fixes into this #808?

tangjiangling · 2022-01-25T04:49:03Z

@zhicwu Do you mind if i merge all the fixes into this #808?

Or is this already all the fixes? No longer need to have #808.

zhicwu · 2022-01-25T05:10:16Z

Or is this already all the fixes? No longer need to have #808.

Thanks for checking @tangjiangling. This pull request contains all the fixes. I think it's safe to close #808, if that's ok for you. Apart from that, I'll commit a few more lines tonight to fix ClickHouseStringValue.hashCode() and maybe the performance penalty(-10%).

github-actions · 2022-01-25T13:05:10Z

Benchmark                                 (client)  (connection)  (statement)  (type)   Mode  Cnt     Score    Error  Units
Basic.insertOneRandomNumber  clickhouse-http-jdbc1         reuse       normal  object  thrpt   20   229.341 ± 30.604  ops/s
Basic.insertOneRandomNumber  clickhouse-http-jdbc1         reuse     prepared  object  thrpt   20   223.563 ± 24.223  ops/s
Basic.insertOneRandomNumber  clickhouse-http-jdbc1           new       normal  object  thrpt   20   223.763 ± 23.694  ops/s
Basic.insertOneRandomNumber  clickhouse-http-jdbc1           new     prepared  object  thrpt   20   224.300 ± 24.856  ops/s
Basic.insertOneRandomNumber   clickhouse-grpc-jdbc         reuse       normal  object  thrpt   20   236.026 ± 26.393  ops/s
Basic.insertOneRandomNumber   clickhouse-grpc-jdbc         reuse     prepared  object  thrpt   20   238.267 ± 24.880  ops/s
Basic.insertOneRandomNumber   clickhouse-grpc-jdbc           new       normal  object  thrpt   20   231.466 ± 24.626  ops/s
Basic.insertOneRandomNumber   clickhouse-grpc-jdbc           new     prepared  object  thrpt   20   238.261 ± 27.944  ops/s
Basic.selectOneRandomNumber  clickhouse-http-jdbc1         reuse       normal  object  thrpt   20  1273.916 ± 87.640  ops/s
Basic.selectOneRandomNumber  clickhouse-http-jdbc1         reuse     prepared  object  thrpt   20  1344.197 ± 91.589  ops/s
Basic.selectOneRandomNumber  clickhouse-http-jdbc1           new       normal  object  thrpt   20  1344.295 ± 72.488  ops/s
Basic.selectOneRandomNumber  clickhouse-http-jdbc1           new     prepared  object  thrpt   20  1323.718 ± 64.596  ops/s
Basic.selectOneRandomNumber   clickhouse-grpc-jdbc         reuse       normal  object  thrpt   20   926.808 ± 59.384  ops/s
Basic.selectOneRandomNumber   clickhouse-grpc-jdbc         reuse     prepared  object  thrpt   20   856.081 ± 61.271  ops/s
Basic.selectOneRandomNumber   clickhouse-grpc-jdbc           new       normal  object  thrpt   20   886.007 ± 72.974  ops/s
Basic.selectOneRandomNumber   clickhouse-grpc-jdbc           new     prepared  object  thrpt   20   891.523 ± 62.431  ops/s

github-actions · 2022-01-25T13:22:49Z

Benchmark                                 (client)  (connection)  (statement)  (type)   Mode  Cnt     Score     Error  Units
Basic.insertOneRandomNumber  clickhouse-http-jdbc1         reuse       normal  object  thrpt   20   229.484 ±  32.889  ops/s
Basic.insertOneRandomNumber  clickhouse-http-jdbc1         reuse     prepared  object  thrpt   20   234.050 ±  30.077  ops/s
Basic.insertOneRandomNumber  clickhouse-http-jdbc1           new       normal  object  thrpt   20   214.545 ±  39.640  ops/s
Basic.insertOneRandomNumber  clickhouse-http-jdbc1           new     prepared  object  thrpt   20   215.086 ±  31.611  ops/s
Basic.insertOneRandomNumber   clickhouse-grpc-jdbc         reuse       normal  object  thrpt   20   228.890 ±  28.501  ops/s
Basic.insertOneRandomNumber   clickhouse-grpc-jdbc         reuse     prepared  object  thrpt   20   236.223 ±  28.689  ops/s
Basic.insertOneRandomNumber   clickhouse-grpc-jdbc           new       normal  object  thrpt   20   201.262 ±  26.862  ops/s
Basic.insertOneRandomNumber   clickhouse-grpc-jdbc           new     prepared  object  thrpt   20   216.987 ±  35.516  ops/s
Basic.selectOneRandomNumber  clickhouse-http-jdbc1         reuse       normal  object  thrpt   20  1563.995 ± 148.159  ops/s
Basic.selectOneRandomNumber  clickhouse-http-jdbc1         reuse     prepared  object  thrpt   20  1633.013 ± 115.324  ops/s
Basic.selectOneRandomNumber  clickhouse-http-jdbc1           new       normal  object  thrpt   20  1614.855 ± 112.903  ops/s
Basic.selectOneRandomNumber  clickhouse-http-jdbc1           new     prepared  object  thrpt   20  1617.748 ±  86.115  ops/s
Basic.selectOneRandomNumber   clickhouse-grpc-jdbc         reuse       normal  object  thrpt   20  1005.226 ±  85.361  ops/s
Basic.selectOneRandomNumber   clickhouse-grpc-jdbc         reuse     prepared  object  thrpt   20  1028.723 ±  76.903  ops/s
Basic.selectOneRandomNumber   clickhouse-grpc-jdbc           new       normal  object  thrpt   20   996.925 ± 116.411  ops/s
Basic.selectOneRandomNumber   clickhouse-grpc-jdbc           new     prepared  object  thrpt   20   928.755 ± 127.765  ops/s

Fix null DECIMAL_DIGITS and CHAR_OCTET_LENGTH

2631c0d

zhicwu linked an issue Jan 18, 2022 that may be closed by this pull request

New Driver returns incorrect precision #807

Closed

Fix test failure

2949c8a

zhicwu mentioned this pull request Jan 19, 2022

Replace deprecated driver ru.yandex.clickhouse.ClickHouseDriver trinodb/trino#10559

Closed

3 tasks

tangjiangling mentioned this pull request Jan 23, 2022

Fix wrong precision #808

Closed

More data type aliases, return scale for number and datetime, and bet…

c9ea0a1

…ter binary string support

Improve binary data support

b11e807

Use null binary value instead of empty byte array

241feb3

zhicwu changed the title ~~Fix incorrect precision returnede from DatabaseMetaData.getColumns~~ Fix incorrect precision and scale from DatabaseMetaData.getColumns Jan 25, 2022

Bump version to 0.3.2-patch3

671cd32

zhicwu merged commit 1f83b42 into ClickHouse:develop Jan 25, 2022

zhicwu deleted the fix-precison branch January 25, 2022 13:23

zhicwu mentioned this pull request Feb 16, 2023

Fail to insert VARBINARY type using clickhouse-jdbc with new driver com.clickhouse.jdbc.ClickHouseDriver #1244

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix incorrect precision and scale from DatabaseMetaData.getColumns#815

Fix incorrect precision and scale from DatabaseMetaData.getColumns#815
zhicwu merged 6 commits intoClickHouse:developfrom
zhicwu:fix-precison

zhicwu commented Jan 18, 2022 •

edited

Loading

Uh oh!

github-actions bot commented Jan 18, 2022

Uh oh!

github-actions bot commented Jan 18, 2022

Uh oh!

github-actions bot commented Jan 24, 2022

Uh oh!

github-actions bot commented Jan 24, 2022

Uh oh!

tangjiangling commented Jan 25, 2022

Uh oh!

tangjiangling commented Jan 25, 2022

Uh oh!

zhicwu commented Jan 25, 2022

Uh oh!

github-actions bot commented Jan 25, 2022

Uh oh!

github-actions bot commented Jan 25, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

zhicwu commented Jan 18, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jan 18, 2022

Uh oh!

github-actions bot commented Jan 18, 2022

Uh oh!

github-actions bot commented Jan 24, 2022

Uh oh!

github-actions bot commented Jan 24, 2022

Uh oh!

tangjiangling commented Jan 25, 2022

Uh oh!

tangjiangling commented Jan 25, 2022

Uh oh!

zhicwu commented Jan 25, 2022

Uh oh!

github-actions bot commented Jan 25, 2022

Uh oh!

github-actions bot commented Jan 25, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

zhicwu commented Jan 18, 2022 •

edited

Loading