Skip to content

Return proper error when user tries to enable transactions #659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zhicwu merged 3 commits into from
May 11, 2021
Merged

Return proper error when user tries to enable transactions #659

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5ca9485
Return correct value from getAutoCommit
findepi May 10, 2021
259682e
Return proper error when user tries to enable transactions
findepi May 10, 2021
d813994
fixup! Return proper error when user tries to enable transactions
findepi May 11, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions clickhouse-jdbc/src/main/java/ru/yandex/clickhouse/ClickHouseConnectionImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,22 +209,25 @@ public String nativeSQL(String sql) throws SQLException {

@Override
public void setAutoCommit(boolean autoCommit) throws SQLException {

if (autoCommit) {
return;
}
throw new SQLFeatureNotSupportedException("Transactions are not supported");
}

@Override
public boolean getAutoCommit() throws SQLException {
return false;
return true;
}

@Override
public void commit() throws SQLException {

throw new SQLException("Cannot commit when auto-commit is enabled");
}

@Override
public void rollback() throws SQLException {

throw new SQLException("Cannot rollback when auto-commit is enabled");
}

@Override
Expand Down