Skip to content

Move query to request body #636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zhicwu merged 1 commit into from
Apr 21, 2021
Merged

Move query to request body #636

zhicwu merged 1 commit into from
Apr 21, 2021

Conversation

@zhicwu
Copy link
Contributor

@zhicwu zhicwu commented Apr 21, 2021 •
edited
Loading

  • query is moved to request body when there's no compression and external data
  • performance is slightly improved after moving query from url to request body

@zhicwu zhicwu linked an issue Apr 21, 2021 that may be closed by this pull request
Long SQL text and external data #634
Closed
@github-actions
Copy link

github-actions bot commented Apr 21, 2021 

Benchmark                           (client)  (statement)   Mode  Cnt     Score     Error  Units
Basic.insertOneRandomNumber  clickhouse-jdbc       normal  thrpt   20   274.899 ±  29.271  ops/s
Basic.insertOneRandomNumber  clickhouse-jdbc     prepared  thrpt   20   266.784 ±  28.132  ops/s
Basic.selectOneRandomNumber  clickhouse-jdbc       normal  thrpt   20  1222.184 ± 174.478  ops/s
Basic.selectOneRandomNumber  clickhouse-jdbc     prepared  thrpt   20  1208.741 ± 180.064  ops/s

@zhicwu zhicwu merged commit 5900247 into ClickHouse:develop Apr 21, 2021
@zhicwu zhicwu deleted the large-request branch April 21, 2021 12:13
This was linked to issues Apr 21, 2021
HTTP GET Request is too big #607
Closed
javacc parser is very slow to parse sql #615
Closed
This was linked to issues Jun 10, 2021
Large requests broken in 0.2+ #412
Closed
does't support large request (>16Kb) #222
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

1 participant

@zhicwu