Skip to content

Fix error when use_new_parser is set to false #618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zhicwu merged 2 commits into from
Apr 10, 2021
Merged

Fix error when use_new_parser is set to false #618

zhicwu merged 2 commits into from
Apr 10, 2021

Conversation

@zhicwu
Copy link
Contributor

@zhicwu zhicwu commented Apr 10, 2021

No description provided.

@zhicwu zhicwu linked an issue Apr 10, 2021 that may be closed by this pull request
javacc parser is very slow to parse sql #615
Closed
@zhicwu
Copy link
Contributor Author

zhicwu commented Apr 10, 2021

When use_new_parser is set to false, the driver should append FORMAT TabSeparatedWithNamesAndTypes to the given query before passing the query to Clickhouse.

@github-actions
Copy link

github-actions bot commented Apr 10, 2021 

Benchmark                           (client)  (statement)   Mode  Cnt       Score       Error  Units
Basic.insertOneRandomNumber  clickhouse-jdbc       normal  thrpt   20  646215.865 ± 46746.104  ops/s
Basic.insertOneRandomNumber  clickhouse-jdbc     prepared  thrpt   20     276.095 ±    30.010  ops/s
Basic.selectOneRandomNumber  clickhouse-jdbc       normal  thrpt   20    1712.657 ±   206.088  ops/s
Basic.selectOneRandomNumber  clickhouse-jdbc     prepared  thrpt   20    1761.727 ±   173.615  ops/s

@github-actions
Copy link

github-actions bot commented Apr 10, 2021 

Benchmark                           (client)  (statement)   Mode  Cnt       Score       Error  Units
Basic.insertOneRandomNumber  clickhouse-jdbc       normal  thrpt   20  558959.864 ± 19928.789  ops/s
Basic.insertOneRandomNumber  clickhouse-jdbc     prepared  thrpt   20     274.867 ±    27.013  ops/s
Basic.selectOneRandomNumber  clickhouse-jdbc       normal  thrpt   20    1345.923 ±   211.813  ops/s
Basic.selectOneRandomNumber  clickhouse-jdbc     prepared  thrpt   20    1354.657 ±   193.988  ops/s

@zhicwu zhicwu merged commit d508f0a into ClickHouse:develop Apr 10, 2021
@zhicwu zhicwu deleted the disable-new-parser branch April 10, 2021 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

javacc parser is very slow to parse sql

1 participant

@zhicwu