Fix http connection reuse #505
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At Datameer, we have had failing communication between client and server when the client reused HTTP connections. When I looked at the code, I noticed that the author(s) of the ConnectionKeepAliveStrategy seemed to think that it does what is actually the purpose of a ConnectionReuseStrategy. The comments within getKeepAliveDuration(..) suggest that they thought that by returning -1 they disable connection reuse (it actually means "keep the connection alive indefinitely"). However, I'm not sure if that is the real root cause of our issues regarding failing communication between client and server when connections are reused, so I designed the new code so that connections are never reused unless told to via property.
Contributor
|
Thanks @kschubert. To respect server keep-alive timeout setting, PR #515 was merged and released in 0.2.5. Connection setting |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At Datameer, we have had failing communication between client and server when the client reused HTTP connections. When I looked at the code, I noticed that the author(s) of the
ConnectionKeepAliveStrategyseemed to think that it does what is actually the purpose of aConnectionReuseStrategy. The comments withingetKeepAliveDuration(..)suggest that they thought that by returning-1they disable connection reuse (it actually means "keep the connection alive indefinitely").However, I'm not sure if that is the real root cause of our issues regarding failing communication between client and server when connections are reused, so I designed the new code so that connections are never reused unless told to via property.