-
Notifications
You must be signed in to change notification settings - Fork 614
Give access to stats returned by server in X-ClickHouse-Summary #498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Give access to stats returned by server in X-ClickHouse-Summary #498
Conversation
|
@bgranvea thanks for PR, any plan to fix ci checks? |
there was an issue not related to this PR, I think it is fixed by 4188aaf I've also added the possibility to add query param before executing it, with the use of ConfigurableApi as it is done in Writer, because I need this in my use case. PR is updated but I don't see the CI results anymore? is there something to do to rerun the tests? |
|
Tests are OK https://travis-ci.org/github/ClickHouse/clickhouse-jdbc/pull_requests |
src/test/java/ru/yandex/clickhouse/integration/ResultSummary.java
Outdated
Show resolved
Hide resolved
src/test/java/ru/yandex/clickhouse/integration/ResultSummary.java
Outdated
Show resolved
Hide resolved
|
Great work @bgranvea! Do you have time to update the PR and re-target to |
- executeUpdate returns real written rows if possible - better unit tests
… we always get read/writtenRows=0)
I've updated with your remarks and rebased on the develop branch. |
Thank you @bgranvea. Could you change merge target from master to develop? |
|
BTW, Number of affected rows will be inaccurate. |
I also noticed that with distributed tables the number of inserted rows is doubled. |
Clickhouse can return interesting statistics in a X-ClickHouse-Summary header if send_progress_in_http_headers parameter is set (see ClickHouse/ClickHouse#5116).
In my use case, I need this to know how many rows are inserted when executing a INSERT ... SELECT ...