Fix tests for new data type Geometry. issue is created and planned #2679
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![windsurf-bot[bot]](https://avatars.githubusercontent.com/in/1066231?s=60&v=4){kind=small}
| } | ||
|
|
||
| assertTrue(nestedTypes.isEmpty(), "Nested types " + nestedTypes + " not found"); | ||
| if (ClickHouseVersion.of(getServerVersion()).check("(,25.10]")) { |
Contributor
There was a problem hiding this comment.
The version check range "(,25.10]" excludes 25.10 from the lower bound and includes it in the upper bound. However, this means the condition will never be true for exactly version 25.10. Consider using "[,25.10]" to include 25.10 in both bounds, or adjust the range based on the exact version where the behavior changed.
Contributor
Author
There was a problem hiding this comment.
Sorry too confusing to understand why upper bound should be included in lower bound.
This expression means that any version from 0 to 25.10 else (when 25.11 or later) do something different.
Client V2 CoverageCoverage Report
Class Coverage
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Geometryto enum. Implementation issue is [client-v2] Add newGeometrytype #2678ObjectChecklist
Delete items not relevant to your PR: