Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[client-v2] Compression Support #1761

Merged
merged 7 commits into from
Aug 6, 2024
Merged

[client-v2] Compression Support #1761

merged 7 commits into from
Aug 6, 2024

Conversation

chernser
Copy link
Contributor

@chernser chernser commented Aug 2, 2024

Summary

Implements support for next compression scenarios:

  • whole http response from a server is compressed with LZ4
    • enabled when server & http compression is enabled
  • response body from a server is compressed with LZ4
  • http request is compressed with LZ4
  • request body is compressed with LZ4

Closes #1717

@chernser chernser marked this pull request as ready for review August 6, 2024 06:20
Copy link
Contributor

@mzitnik mzitnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general LGTM, but we need to add tests that can mimic different chunk sizes to simulate edge cases for the compression.

super();
this.decompressor = decompressor;
this.in = in;
this.buffer = ByteBuffer.allocate(8192);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's extract it to const & make configurable

Copy link

sonarcloud bot commented Aug 6, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
23.3% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@chernser chernser merged commit 3a82665 into main Aug 6, 2024
65 of 66 checks passed
@chernser chernser deleted the feat_compression_support branch August 6, 2024 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[client-v2] Compression
2 participants