-
Notifications
You must be signed in to change notification settings - Fork 562
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use any
instead of interface{}
#984
Conversation
Hi @alexey-milovidov! |
@candiduslynx I will review it once have checks green. |
@jkaflik It seems that the failing test is flaky (failed to dial?) Could you trigger the rerun of failed jobs? |
@candiduslynx given our workflow setup, it's expected to fail on the fork run. Please do not worry about it. |
@jkaflik |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Staging for a release
BTW, I didn't include a lot of the linters (like, errcheck) because it highlights a lot of issues, and I feel like you'll need to address those specifically (remove the disable all, add other linters. Example cfg we have in CQ SDK: https://github.com/cloudquery/plugin-sdk/blob/main/.golangci.yml) |
@jkaflik could you point me to some doc or walk through the RC process for SDK? Are you performing some internal testing to ensure consistency and then merge manually? Or is there something you tweak and then the (just curios) |
@candiduslynx, we don't have (yet) a formalized release process for SDKs. Currently, I stage non-critical PRs with a label and merge them before major/minor release. Issue with running tests against cloud on fork PRs can be tracked here. |
@jkaflik thanks for explaining! Would you consider merging this earlier, as this includes linter rules to ensure |
any
instead of interface{}
any
instead of interface{}
Summary
Go 1.18 (that is targeted by go.mod) introduced a handy
any
alias forinterface{}
, so use it for reading & dev simplicity.Checklist
Delete items not relevant to your PR: