Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix panic on nil map append #1383

Merged
merged 1 commit into from
Aug 23, 2024
Merged

Fix panic on nil map append #1383

merged 1 commit into from
Aug 23, 2024

Conversation

jkaflik
Copy link
Contributor

@jkaflik jkaflik commented Aug 22, 2024

An appropriate error message will be return instead.

resolves #1371

@jkaflik jkaflik self-assigned this Aug 22, 2024
@jkaflik jkaflik merged commit 37afb6f into main Aug 23, 2024
12 checks passed
codeboten referenced this pull request in open-telemetry/opentelemetry-collector-contrib Aug 27, 2024
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
|
[github.com/ClickHouse/clickhouse-go/v2](https://github.com/ClickHouse/clickhouse-go)
| `v2.27.2` -> `v2.28.1` |
[![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fClickHouse%2fclickhouse-go%2fv2/v2.28.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fClickHouse%2fclickhouse-go%2fv2/v2.28.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fClickHouse%2fclickhouse-go%2fv2/v2.27.2/v2.28.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fClickHouse%2fclickhouse-go%2fv2/v2.27.2/v2.28.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.

---

### Release Notes

<details>
<summary>ClickHouse/clickhouse-go
(github.com/ClickHouse/clickhouse-go/v2)</summary>

###
[`v2.28.1`](https://github.com/ClickHouse/clickhouse-go/blob/HEAD/CHANGELOG.md#v2281-2024-08-27----Release-notes-generated-using-configuration-in-githubreleaseyml-at-main---)

[Compare
Source](https://github.com/ClickHouse/clickhouse-go/compare/v2.28.0...v2.28.1)

#### What's Changed

##### Fixes 🐛

- Recognize empty strings as a valid enum key by
[@&#8203;genzgd](https://github.com/genzgd) in
[https://github.com/ClickHouse/clickhouse-go/pull/1387](https://github.com/ClickHouse/clickhouse-go/pull/1387)

##### Other Changes 🛠

- ClickHouse 24.8 by [@&#8203;jkaflik](https://github.com/jkaflik) in
[https://github.com/ClickHouse/clickhouse-go/pull/1385](https://github.com/ClickHouse/clickhouse-go/pull/1385)

**Full Changelog**:
ClickHouse/clickhouse-go@v2.28.0...v2.28.1

###
[`v2.28.0`](https://github.com/ClickHouse/clickhouse-go/blob/HEAD/CHANGELOG.md#v2280-2024-08-23----Release-notes-generated-using-configuration-in-githubreleaseyml-at-main---)

[Compare
Source](https://github.com/ClickHouse/clickhouse-go/compare/v2.27.2...v2.28.0)

#### What's Changed

##### Fixes 🐛

- Fix Enum column definition parse logic to match ClickHouse spec by
[@&#8203;jkaflik](https://github.com/jkaflik) in
[https://github.com/ClickHouse/clickhouse-go/pull/1380](https://github.com/ClickHouse/clickhouse-go/pull/1380)
- Fix support custom serialization in Nested type by
[@&#8203;jkaflik](https://github.com/jkaflik) in
[https://github.com/ClickHouse/clickhouse-go/pull/1381](https://github.com/ClickHouse/clickhouse-go/pull/1381)
- Fix panic on nil map append by
[@&#8203;jkaflik](https://github.com/jkaflik) in
[https://github.com/ClickHouse/clickhouse-go/pull/1383](https://github.com/ClickHouse/clickhouse-go/pull/1383)

##### Other Changes 🛠

- Remove test coverage for deprecated Object('JSON') type by
[@&#8203;jkaflik](https://github.com/jkaflik) in
[https://github.com/ClickHouse/clickhouse-go/pull/1377](https://github.com/ClickHouse/clickhouse-go/pull/1377)
- Remove JSON type use from a context use example by
[@&#8203;jkaflik](https://github.com/jkaflik) in
[https://github.com/ClickHouse/clickhouse-go/pull/1379](https://github.com/ClickHouse/clickhouse-go/pull/1379)
- Make sure non-secure port is used during readiness check by
[@&#8203;jkaflik](https://github.com/jkaflik) in
[https://github.com/ClickHouse/clickhouse-go/pull/1382](https://github.com/ClickHouse/clickhouse-go/pull/1382)
- Deprecate Go 1.21 ended support and require Go 1.22 by
[@&#8203;jkaflik](https://github.com/jkaflik) in
[https://github.com/ClickHouse/clickhouse-go/pull/1378](https://github.com/ClickHouse/clickhouse-go/pull/1378)

**Full Changelog**:
ClickHouse/clickhouse-go@v2.27.2...v2.28.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any
time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR was generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View the
[repository job
log](https://developer.mend.io/github/open-telemetry/opentelemetry-collector-contrib).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC4yNi4xIiwidXBkYXRlZEluVmVyIjoiMzguMjYuMSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiZGVwZW5kZW5jaWVzIiwicmVub3ZhdGVib3QiXX0=-->

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: opentelemetrybot <[email protected]>
@jkaflik jkaflik deleted the kk/fix-nil-map-append-panic branch August 28, 2024 06:05
f7o referenced this pull request in f7o/opentelemetry-collector-contrib Sep 12, 2024
…-telemetry#34866)

[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
|
[github.com/ClickHouse/clickhouse-go/v2](https://github.com/ClickHouse/clickhouse-go)
| `v2.27.2` -> `v2.28.1` |
[![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fClickHouse%2fclickhouse-go%2fv2/v2.28.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fClickHouse%2fclickhouse-go%2fv2/v2.28.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fClickHouse%2fclickhouse-go%2fv2/v2.27.2/v2.28.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fClickHouse%2fclickhouse-go%2fv2/v2.27.2/v2.28.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.

---

### Release Notes

<details>
<summary>ClickHouse/clickhouse-go
(github.com/ClickHouse/clickhouse-go/v2)</summary>

###
[`v2.28.1`](https://github.com/ClickHouse/clickhouse-go/blob/HEAD/CHANGELOG.md#v2281-2024-08-27----Release-notes-generated-using-configuration-in-githubreleaseyml-at-main---)

[Compare
Source](https://github.com/ClickHouse/clickhouse-go/compare/v2.28.0...v2.28.1)

#### What's Changed

##### Fixes 🐛

- Recognize empty strings as a valid enum key by
[@&open-telemetry#8203;genzgd](https://github.com/genzgd) in
[https://github.com/ClickHouse/clickhouse-go/pull/1387](https://github.com/ClickHouse/clickhouse-go/pull/1387)

##### Other Changes 🛠

- ClickHouse 24.8 by [@&open-telemetry#8203;jkaflik](https://github.com/jkaflik) in
[https://github.com/ClickHouse/clickhouse-go/pull/1385](https://github.com/ClickHouse/clickhouse-go/pull/1385)

**Full Changelog**:
ClickHouse/clickhouse-go@v2.28.0...v2.28.1

###
[`v2.28.0`](https://github.com/ClickHouse/clickhouse-go/blob/HEAD/CHANGELOG.md#v2280-2024-08-23----Release-notes-generated-using-configuration-in-githubreleaseyml-at-main---)

[Compare
Source](https://github.com/ClickHouse/clickhouse-go/compare/v2.27.2...v2.28.0)

#### What's Changed

##### Fixes 🐛

- Fix Enum column definition parse logic to match ClickHouse spec by
[@&open-telemetry#8203;jkaflik](https://github.com/jkaflik) in
[https://github.com/ClickHouse/clickhouse-go/pull/1380](https://github.com/ClickHouse/clickhouse-go/pull/1380)
- Fix support custom serialization in Nested type by
[@&open-telemetry#8203;jkaflik](https://github.com/jkaflik) in
[https://github.com/ClickHouse/clickhouse-go/pull/1381](https://github.com/ClickHouse/clickhouse-go/pull/1381)
- Fix panic on nil map append by
[@&open-telemetry#8203;jkaflik](https://github.com/jkaflik) in
[https://github.com/ClickHouse/clickhouse-go/pull/1383](https://github.com/ClickHouse/clickhouse-go/pull/1383)

##### Other Changes 🛠

- Remove test coverage for deprecated Object('JSON') type by
[@&open-telemetry#8203;jkaflik](https://github.com/jkaflik) in
[https://github.com/ClickHouse/clickhouse-go/pull/1377](https://github.com/ClickHouse/clickhouse-go/pull/1377)
- Remove JSON type use from a context use example by
[@&open-telemetry#8203;jkaflik](https://github.com/jkaflik) in
[https://github.com/ClickHouse/clickhouse-go/pull/1379](https://github.com/ClickHouse/clickhouse-go/pull/1379)
- Make sure non-secure port is used during readiness check by
[@&open-telemetry#8203;jkaflik](https://github.com/jkaflik) in
[https://github.com/ClickHouse/clickhouse-go/pull/1382](https://github.com/ClickHouse/clickhouse-go/pull/1382)
- Deprecate Go 1.21 ended support and require Go 1.22 by
[@&open-telemetry#8203;jkaflik](https://github.com/jkaflik) in
[https://github.com/ClickHouse/clickhouse-go/pull/1378](https://github.com/ClickHouse/clickhouse-go/pull/1378)

**Full Changelog**:
ClickHouse/clickhouse-go@v2.27.2...v2.28.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any
time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR was generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View the
[repository job
log](https://developer.mend.io/github/open-telemetry/opentelemetry-collector-contrib).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC4yNi4xIiwidXBkYXRlZEluVmVyIjoiMzguMjYuMSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiZGVwZW5kZW5jaWVzIiwicmVub3ZhdGVib3QiXX0=-->

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: opentelemetrybot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Panic occurs but is never thrown when inserting a nil value in a Map() column
1 participant