Remove test coverage for deprecated Object('JSON') type #1377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ClickHouse has deprecated support for (https://clickhouse.com/docs/en/sql-reference/data-types/object-data-type. Object('JSON') has been aliased with JSON for a long time in ClickHouse as an experimental type. It's replaced by a new JSON type: https://clickhouse.com/docs/en/sql-reference/data-types/newjson (still experimental) clickhouse-go implements support for Object('JSON'), but not for a new JSON type. To avoid confusion, all test coverage and mentions are removed for the deprecated type. New JSON type support needs to be implemented in clickhouse-go.
codeboten
referenced
this pull request
in open-telemetry/opentelemetry-collector-contrib
Aug 27, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/ClickHouse/clickhouse-go/v2](https://github.com/ClickHouse/clickhouse-go) | `v2.27.2` -> `v2.28.1` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>ClickHouse/clickhouse-go (github.com/ClickHouse/clickhouse-go/v2)</summary> ### [`v2.28.1`](https://github.com/ClickHouse/clickhouse-go/blob/HEAD/CHANGELOG.md#v2281-2024-08-27----Release-notes-generated-using-configuration-in-githubreleaseyml-at-main---) [Compare Source](https://github.com/ClickHouse/clickhouse-go/compare/v2.28.0...v2.28.1) #### What's Changed ##### Fixes 🐛 - Recognize empty strings as a valid enum key by [@​genzgd](https://github.com/genzgd) in [https://github.com/ClickHouse/clickhouse-go/pull/1387](https://github.com/ClickHouse/clickhouse-go/pull/1387) ##### Other Changes 🛠 - ClickHouse 24.8 by [@​jkaflik](https://github.com/jkaflik) in [https://github.com/ClickHouse/clickhouse-go/pull/1385](https://github.com/ClickHouse/clickhouse-go/pull/1385) **Full Changelog**: ClickHouse/clickhouse-go@v2.28.0...v2.28.1 ### [`v2.28.0`](https://github.com/ClickHouse/clickhouse-go/blob/HEAD/CHANGELOG.md#v2280-2024-08-23----Release-notes-generated-using-configuration-in-githubreleaseyml-at-main---) [Compare Source](https://github.com/ClickHouse/clickhouse-go/compare/v2.27.2...v2.28.0) #### What's Changed ##### Fixes 🐛 - Fix Enum column definition parse logic to match ClickHouse spec by [@​jkaflik](https://github.com/jkaflik) in [https://github.com/ClickHouse/clickhouse-go/pull/1380](https://github.com/ClickHouse/clickhouse-go/pull/1380) - Fix support custom serialization in Nested type by [@​jkaflik](https://github.com/jkaflik) in [https://github.com/ClickHouse/clickhouse-go/pull/1381](https://github.com/ClickHouse/clickhouse-go/pull/1381) - Fix panic on nil map append by [@​jkaflik](https://github.com/jkaflik) in [https://github.com/ClickHouse/clickhouse-go/pull/1383](https://github.com/ClickHouse/clickhouse-go/pull/1383) ##### Other Changes 🛠 - Remove test coverage for deprecated Object('JSON') type by [@​jkaflik](https://github.com/jkaflik) in [https://github.com/ClickHouse/clickhouse-go/pull/1377](https://github.com/ClickHouse/clickhouse-go/pull/1377) - Remove JSON type use from a context use example by [@​jkaflik](https://github.com/jkaflik) in [https://github.com/ClickHouse/clickhouse-go/pull/1379](https://github.com/ClickHouse/clickhouse-go/pull/1379) - Make sure non-secure port is used during readiness check by [@​jkaflik](https://github.com/jkaflik) in [https://github.com/ClickHouse/clickhouse-go/pull/1382](https://github.com/ClickHouse/clickhouse-go/pull/1382) - Deprecate Go 1.21 ended support and require Go 1.22 by [@​jkaflik](https://github.com/jkaflik) in [https://github.com/ClickHouse/clickhouse-go/pull/1378](https://github.com/ClickHouse/clickhouse-go/pull/1378) **Full Changelog**: ClickHouse/clickhouse-go@v2.27.2...v2.28.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View the [repository job log](https://developer.mend.io/github/open-telemetry/opentelemetry-collector-contrib). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC4yNi4xIiwidXBkYXRlZEluVmVyIjoiMzguMjYuMSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiZGVwZW5kZW5jaWVzIiwicmVub3ZhdGVib3QiXX0=--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: opentelemetrybot <[email protected]>
f7o
referenced
this pull request
in f7o/opentelemetry-collector-contrib
Sep 12, 2024
](https://renovatebot.com){kind=link}
…-telemetry#34866) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/ClickHouse/clickhouse-go/v2](https://github.com/ClickHouse/clickhouse-go) | `v2.27.2` -> `v2.28.1` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>ClickHouse/clickhouse-go (github.com/ClickHouse/clickhouse-go/v2)</summary> ### [`v2.28.1`](https://github.com/ClickHouse/clickhouse-go/blob/HEAD/CHANGELOG.md#v2281-2024-08-27----Release-notes-generated-using-configuration-in-githubreleaseyml-at-main---) [Compare Source](https://github.com/ClickHouse/clickhouse-go/compare/v2.28.0...v2.28.1) #### What's Changed ##### Fixes 🐛 - Recognize empty strings as a valid enum key by [@&open-telemetry#8203;genzgd](https://github.com/genzgd) in [https://github.com/ClickHouse/clickhouse-go/pull/1387](https://github.com/ClickHouse/clickhouse-go/pull/1387) ##### Other Changes 🛠 - ClickHouse 24.8 by [@&open-telemetry#8203;jkaflik](https://github.com/jkaflik) in [https://github.com/ClickHouse/clickhouse-go/pull/1385](https://github.com/ClickHouse/clickhouse-go/pull/1385) **Full Changelog**: ClickHouse/clickhouse-go@v2.28.0...v2.28.1 ### [`v2.28.0`](https://github.com/ClickHouse/clickhouse-go/blob/HEAD/CHANGELOG.md#v2280-2024-08-23----Release-notes-generated-using-configuration-in-githubreleaseyml-at-main---) [Compare Source](https://github.com/ClickHouse/clickhouse-go/compare/v2.27.2...v2.28.0) #### What's Changed ##### Fixes 🐛 - Fix Enum column definition parse logic to match ClickHouse spec by [@&open-telemetry#8203;jkaflik](https://github.com/jkaflik) in [https://github.com/ClickHouse/clickhouse-go/pull/1380](https://github.com/ClickHouse/clickhouse-go/pull/1380) - Fix support custom serialization in Nested type by [@&open-telemetry#8203;jkaflik](https://github.com/jkaflik) in [https://github.com/ClickHouse/clickhouse-go/pull/1381](https://github.com/ClickHouse/clickhouse-go/pull/1381) - Fix panic on nil map append by [@&open-telemetry#8203;jkaflik](https://github.com/jkaflik) in [https://github.com/ClickHouse/clickhouse-go/pull/1383](https://github.com/ClickHouse/clickhouse-go/pull/1383) ##### Other Changes 🛠 - Remove test coverage for deprecated Object('JSON') type by [@&open-telemetry#8203;jkaflik](https://github.com/jkaflik) in [https://github.com/ClickHouse/clickhouse-go/pull/1377](https://github.com/ClickHouse/clickhouse-go/pull/1377) - Remove JSON type use from a context use example by [@&open-telemetry#8203;jkaflik](https://github.com/jkaflik) in [https://github.com/ClickHouse/clickhouse-go/pull/1379](https://github.com/ClickHouse/clickhouse-go/pull/1379) - Make sure non-secure port is used during readiness check by [@&open-telemetry#8203;jkaflik](https://github.com/jkaflik) in [https://github.com/ClickHouse/clickhouse-go/pull/1382](https://github.com/ClickHouse/clickhouse-go/pull/1382) - Deprecate Go 1.21 ended support and require Go 1.22 by [@&open-telemetry#8203;jkaflik](https://github.com/jkaflik) in [https://github.com/ClickHouse/clickhouse-go/pull/1378](https://github.com/ClickHouse/clickhouse-go/pull/1378) **Full Changelog**: ClickHouse/clickhouse-go@v2.27.2...v2.28.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View the [repository job log](https://developer.mend.io/github/open-telemetry/opentelemetry-collector-contrib). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC4yNi4xIiwidXBkYXRlZEluVmVyIjoiMzguMjYuMSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiZGVwZW5kZW5jaWVzIiwicmVub3ZhdGVib3QiXX0=--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: opentelemetrybot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ClickHouse has deprecated support for (https://clickhouse.com/docs/en/sql-reference/data-types/object-data-type. Object('JSON') has been aliased with JSON for a long time in ClickHouse as an experimental type. It's replaced by a new JSON type: https://clickhouse.com/docs/en/sql-reference/data-types/newjson (still experimental)
clickhouse-go implements support for Object('JSON'), but not for a new JSON type. To avoid confusion, all test coverage and mentions are removed for the deprecated type. Type support will be kept for backwards compatibility, without further support.
New JSON type support needs to be implemented in clickhouse-go.