-
Notifications
You must be signed in to change notification settings - Fork 562
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize Date/Date32 scan #1374
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkaflik
approved these changes
Aug 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for your contribution!
TylerHelmuth
referenced
this pull request
in open-telemetry/opentelemetry-collector-contrib
Aug 20, 2024
….27.2 (#34752) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/ClickHouse/clickhouse-go/v2](https://github.com/ClickHouse/clickhouse-go) | `v2.27.1` -> `v2.27.2` | [![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fClickHouse%2fclickhouse-go%2fv2/v2.27.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fClickHouse%2fclickhouse-go%2fv2/v2.27.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fClickHouse%2fclickhouse-go%2fv2/v2.27.1/v2.27.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fClickHouse%2fclickhouse-go%2fv2/v2.27.1/v2.27.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>ClickHouse/clickhouse-go (github.com/ClickHouse/clickhouse-go/v2)</summary> ### [`v2.27.2`](https://github.com/ClickHouse/clickhouse-go/blob/HEAD/CHANGELOG.md#v2272-2024-08-20----Release-notes-generated-using-configuration-in-githubreleaseyml-at-main---) [Compare Source](https://github.com/ClickHouse/clickhouse-go/compare/v2.27.1...v2.27.2) #### What's Changed ##### Enhancements 🎉 - Optimize Date/Date32 scan by [@​ShoshinNikita](https://github.com/ShoshinNikita) in [https://github.com/ClickHouse/clickhouse-go/pull/1374](https://github.com/ClickHouse/clickhouse-go/pull/1374) ##### Fixes 🐛 - Fix column list parsing for multiline INSERT statements by [@​Fiery-Fenix](https://github.com/Fiery-Fenix) in [https://github.com/ClickHouse/clickhouse-go/pull/1373](https://github.com/ClickHouse/clickhouse-go/pull/1373) #### New Contributors - [@​Fiery-Fenix](https://github.com/Fiery-Fenix) made their first contribution in [https://github.com/ClickHouse/clickhouse-go/pull/1373](https://github.com/ClickHouse/clickhouse-go/pull/1373) - [@​ShoshinNikita](https://github.com/ShoshinNikita) made their first contribution in [https://github.com/ClickHouse/clickhouse-go/pull/1374](https://github.com/ClickHouse/clickhouse-go/pull/1374) **Full Changelog**: ClickHouse/clickhouse-go@v2.27.1...v2.27.2 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View the [repository job log](https://developer.mend.io/github/open-telemetry/opentelemetry-collector-contrib). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC4yNi4xIiwidXBkYXRlZEluVmVyIjoiMzguMjYuMSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiZGVwZW5kZW5jaWVzIiwicmVub3ZhdGVib3QiXX0=--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: opentelemetrybot <[email protected]> Co-authored-by: Yang Song <[email protected]>
f7o
referenced
this pull request
in f7o/opentelemetry-collector-contrib
Sep 12, 2024
….27.2 (open-telemetry#34752) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/ClickHouse/clickhouse-go/v2](https://github.com/ClickHouse/clickhouse-go) | `v2.27.1` -> `v2.27.2` | [![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fClickHouse%2fclickhouse-go%2fv2/v2.27.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fClickHouse%2fclickhouse-go%2fv2/v2.27.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fClickHouse%2fclickhouse-go%2fv2/v2.27.1/v2.27.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fClickHouse%2fclickhouse-go%2fv2/v2.27.1/v2.27.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>ClickHouse/clickhouse-go (github.com/ClickHouse/clickhouse-go/v2)</summary> ### [`v2.27.2`](https://github.com/ClickHouse/clickhouse-go/blob/HEAD/CHANGELOG.md#v2272-2024-08-20----Release-notes-generated-using-configuration-in-githubreleaseyml-at-main---) [Compare Source](https://github.com/ClickHouse/clickhouse-go/compare/v2.27.1...v2.27.2) #### What's Changed ##### Enhancements 🎉 - Optimize Date/Date32 scan by [@&open-telemetry#8203;ShoshinNikita](https://github.com/ShoshinNikita) in [https://github.com/ClickHouse/clickhouse-go/pull/1374](https://github.com/ClickHouse/clickhouse-go/pull/1374) ##### Fixes 🐛 - Fix column list parsing for multiline INSERT statements by [@&open-telemetry#8203;Fiery-Fenix](https://github.com/Fiery-Fenix) in [https://github.com/ClickHouse/clickhouse-go/pull/1373](https://github.com/ClickHouse/clickhouse-go/pull/1373) #### New Contributors - [@&open-telemetry#8203;Fiery-Fenix](https://github.com/Fiery-Fenix) made their first contribution in [https://github.com/ClickHouse/clickhouse-go/pull/1373](https://github.com/ClickHouse/clickhouse-go/pull/1373) - [@&open-telemetry#8203;ShoshinNikita](https://github.com/ShoshinNikita) made their first contribution in [https://github.com/ClickHouse/clickhouse-go/pull/1374](https://github.com/ClickHouse/clickhouse-go/pull/1374) **Full Changelog**: ClickHouse/clickhouse-go@v2.27.1...v2.27.2 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View the [repository job log](https://developer.mend.io/github/open-telemetry/opentelemetry-collector-contrib). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC4yNi4xIiwidXBkYXRlZEluVmVyIjoiMzguMjYuMSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiZGVwZW5kZW5jaWVzIiwicmVub3ZhdGVib3QiXX0=--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: opentelemetrybot <[email protected]> Co-authored-by: Yang Song <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
time.Time.Date
and hour, minute, seconds viatime.Time.Clock
. This change eliminates multiple calls totime.Time.date
andtime.Time.abs
.time.Time
if desired location isUTC
.Benchmark results of
getTimeWithDifferentLocation
:Raw benchmark results
Old version
Optimized version
Checklist
Delete items not relevant to your PR: