-
Notifications
You must be signed in to change notification settings - Fork 562
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error channel deadlock fix test case #1239
Merged
jkaflik
merged 2 commits into
ClickHouse:main
from
threadedstream:add_buffered_errors_test_case
Mar 19, 2024
Merged
Error channel deadlock fix test case #1239
jkaflik
merged 2 commits into
ClickHouse:main
from
threadedstream:add_buffered_errors_test_case
Mar 19, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkaflik
approved these changes
Mar 19, 2024
dmitryax
referenced
this pull request
in open-telemetry/opentelemetry-collector-contrib
Mar 26, 2024
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/ClickHouse/clickhouse-go/v2](https://github.com/ClickHouse/clickhouse-go) | `v2.22.2` -> `v2.22.4` | [![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fClickHouse%2fclickhouse-go%2fv2/v2.22.4?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fClickHouse%2fclickhouse-go%2fv2/v2.22.4?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fClickHouse%2fclickhouse-go%2fv2/v2.22.2/v2.22.4?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fClickHouse%2fclickhouse-go%2fv2/v2.22.2/v2.22.4?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>ClickHouse/clickhouse-go (github.com/ClickHouse/clickhouse-go/v2)</summary> ### [`v2.22.4`](https://github.com/ClickHouse/clickhouse-go/blob/HEAD/CHANGELOG.md#v2224-2024-03-25----Release-notes-generated-using-configuration-in-githubreleaseyml-at-main---) [Compare Source](https://github.com/ClickHouse/clickhouse-go/compare/v2.22.3...v2.22.4) #### What's Changed ##### Fixes 🐛 - Fix column name with parantheses handle in prepare batch by [@​jkaflik](https://github.com/jkaflik) in [https://github.com/ClickHouse/clickhouse-go/pull/1252](https://github.com/ClickHouse/clickhouse-go/pull/1252) ##### Other Changes 🛠 - Fix TestBatchAppendRows work different on cloud by [@​jkaflik](https://github.com/jkaflik) in [https://github.com/ClickHouse/clickhouse-go/pull/1251](https://github.com/ClickHouse/clickhouse-go/pull/1251) **Full Changelog**: ClickHouse/clickhouse-go@v2.22.3...v2.22.4 ### [`v2.22.3`](https://github.com/ClickHouse/clickhouse-go/blob/HEAD/CHANGELOG.md#v2223-2024-03-25----Release-notes-generated-using-configuration-in-githubreleaseyml-at-main---) [Compare Source](https://github.com/ClickHouse/clickhouse-go/compare/v2.22.2...v2.22.3) #### What's Changed ##### Fixes 🐛 - Fix panic on tuple scan on \[]any by [@​jkaflik](https://github.com/jkaflik) in [https://github.com/ClickHouse/clickhouse-go/pull/1249](https://github.com/ClickHouse/clickhouse-go/pull/1249) ##### Other Changes 🛠 - Error channel deadlock fix test case by [@​threadedstream](https://github.com/threadedstream) in [https://github.com/ClickHouse/clickhouse-go/pull/1239](https://github.com/ClickHouse/clickhouse-go/pull/1239) - Add a test case for [#​1127](https://github.com/ClickHouse/clickhouse-go/issues/1127) by [@​jkaflik](https://github.com/jkaflik) in [https://github.com/ClickHouse/clickhouse-go/pull/1242](https://github.com/ClickHouse/clickhouse-go/pull/1242) - Run cloud/head jobs when label by [@​jkaflik](https://github.com/jkaflik) in [https://github.com/ClickHouse/clickhouse-go/pull/1250](https://github.com/ClickHouse/clickhouse-go/pull/1250) **Full Changelog**: ClickHouse/clickhouse-go@v2.22.2...v2.22.3 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/open-telemetry/opentelemetry-collector-contrib). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yNjkuMiIsInVwZGF0ZWRJblZlciI6IjM3LjI2OS4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: opentelemetrybot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
A small test case for #1229