Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support bool alias type #1156

Merged
merged 3 commits into from
Dec 19, 2023
Merged

Conversation

yogasw
Copy link
Contributor

@yogasw yogasw commented Dec 8, 2023

Summary

closes #1154

@CLAassistant
Copy link

CLAassistant commented Dec 8, 2023

CLA assistant check
All committers have signed the CLA.

@jkaflik jkaflik self-requested a review December 8, 2023 10:08
@jkaflik jkaflik changed the title support custom bool Support bool alias type Dec 8, 2023
Copy link
Contributor

@jkaflik jkaflik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is one code improvement. I will submit it.

lib/column/bool.go Outdated Show resolved Hide resolved
@jkaflik jkaflik merged commit cb7bdb4 into ClickHouse:main Dec 19, 2023
13 checks passed
mx-psi referenced this pull request in open-telemetry/opentelemetry-collector-contrib Jan 3, 2024
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
|
[github.com/ClickHouse/clickhouse-go/v2](https://github.com/ClickHouse/clickhouse-go)
| `v2.16.0` -> `v2.17.0` |
[![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fClickHouse%2fclickhouse-go%2fv2/v2.17.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fClickHouse%2fclickhouse-go%2fv2/v2.17.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fClickHouse%2fclickhouse-go%2fv2/v2.16.0/v2.17.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fClickHouse%2fclickhouse-go%2fv2/v2.16.0/v2.17.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>ClickHouse/clickhouse-go
(github.com/ClickHouse/clickhouse-go/v2)</summary>

###
[`v2.17.0`](https://github.com/ClickHouse/clickhouse-go/blob/HEAD/CHANGELOG.md#v2170-2023-12-21----Release-notes-generated-using-configuration-in-githubreleaseyml-at-main---)

[Compare
Source](https://github.com/ClickHouse/clickhouse-go/compare/v2.16.0...v2.17.0)

#### What's Changed

##### Enhancements 🎉

- Iterable ordered map alternative with improved performance by
[@&#8203;hanjm](https://github.com/hanjm) in
[https://github.com/ClickHouse/clickhouse-go/pull/1152](https://github.com/ClickHouse/clickhouse-go/pull/1152)
- Support bool alias type by
[@&#8203;yogasw](https://github.com/yogasw) in
[https://github.com/ClickHouse/clickhouse-go/pull/1156](https://github.com/ClickHouse/clickhouse-go/pull/1156)

##### Fixes 🐛

- Update README - mention HTTP protocol usable only with `database/sql`
interface by [@&#8203;jkaflik](https://github.com/jkaflik) in
[https://github.com/ClickHouse/clickhouse-go/pull/1160](https://github.com/ClickHouse/clickhouse-go/pull/1160)
- Fix README example for Debugf by
[@&#8203;aramperes](https://github.com/aramperes) in
[https://github.com/ClickHouse/clickhouse-go/pull/1153](https://github.com/ClickHouse/clickhouse-go/pull/1153)

#### New Contributors

- [@&#8203;yogasw](https://github.com/yogasw) made their first
contribution in
[https://github.com/ClickHouse/clickhouse-go/pull/1156](https://github.com/ClickHouse/clickhouse-go/pull/1156)
- [@&#8203;aramperes](https://github.com/aramperes) made their first
contribution in
[https://github.com/ClickHouse/clickhouse-go/pull/1153](https://github.com/ClickHouse/clickhouse-go/pull/1153)

**Full Changelog**:
ClickHouse/clickhouse-go@v2.16.0...v2.17.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any
time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/open-telemetry/opentelemetry-collector-contrib).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xMDMuMSIsInVwZGF0ZWRJblZlciI6IjM3LjEwMy4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: opentelemetrybot <[email protected]>
Co-authored-by: Bogdan Drutu <[email protected]>
cparkins referenced this pull request in AmadeusITGroup/opentelemetry-collector-contrib Jan 10, 2024
…-telemetry#30217)

[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
|
[github.com/ClickHouse/clickhouse-go/v2](https://github.com/ClickHouse/clickhouse-go)
| `v2.16.0` -> `v2.17.0` |
[![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fClickHouse%2fclickhouse-go%2fv2/v2.17.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fClickHouse%2fclickhouse-go%2fv2/v2.17.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fClickHouse%2fclickhouse-go%2fv2/v2.16.0/v2.17.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fClickHouse%2fclickhouse-go%2fv2/v2.16.0/v2.17.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>ClickHouse/clickhouse-go
(github.com/ClickHouse/clickhouse-go/v2)</summary>

###
[`v2.17.0`](https://github.com/ClickHouse/clickhouse-go/blob/HEAD/CHANGELOG.md#v2170-2023-12-21----Release-notes-generated-using-configuration-in-githubreleaseyml-at-main---)

[Compare
Source](https://github.com/ClickHouse/clickhouse-go/compare/v2.16.0...v2.17.0)

#### What's Changed

##### Enhancements 🎉

- Iterable ordered map alternative with improved performance by
[@&open-telemetry#8203;hanjm](https://github.com/hanjm) in
[https://github.com/ClickHouse/clickhouse-go/pull/1152](https://github.com/ClickHouse/clickhouse-go/pull/1152)
- Support bool alias type by
[@&open-telemetry#8203;yogasw](https://github.com/yogasw) in
[https://github.com/ClickHouse/clickhouse-go/pull/1156](https://github.com/ClickHouse/clickhouse-go/pull/1156)

##### Fixes 🐛

- Update README - mention HTTP protocol usable only with `database/sql`
interface by [@&open-telemetry#8203;jkaflik](https://github.com/jkaflik) in
[https://github.com/ClickHouse/clickhouse-go/pull/1160](https://github.com/ClickHouse/clickhouse-go/pull/1160)
- Fix README example for Debugf by
[@&open-telemetry#8203;aramperes](https://github.com/aramperes) in
[https://github.com/ClickHouse/clickhouse-go/pull/1153](https://github.com/ClickHouse/clickhouse-go/pull/1153)

#### New Contributors

- [@&open-telemetry#8203;yogasw](https://github.com/yogasw) made their first
contribution in
[https://github.com/ClickHouse/clickhouse-go/pull/1156](https://github.com/ClickHouse/clickhouse-go/pull/1156)
- [@&open-telemetry#8203;aramperes](https://github.com/aramperes) made their first
contribution in
[https://github.com/ClickHouse/clickhouse-go/pull/1153](https://github.com/ClickHouse/clickhouse-go/pull/1153)

**Full Changelog**:
ClickHouse/clickhouse-go@v2.16.0...v2.17.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any
time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/open-telemetry/opentelemetry-collector-contrib).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xMDMuMSIsInVwZGF0ZWRJblZlciI6IjM3LjEwMy4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: opentelemetrybot <[email protected]>
Co-authored-by: Bogdan Drutu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Native Driver support for Custom Bool type in struct
3 participants