Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix README example for Debugf #1153

Merged
merged 1 commit into from
Dec 19, 2023
Merged

Fix README example for Debugf #1153

merged 1 commit into from
Dec 19, 2023

Conversation

aramperes
Copy link
Contributor

Summary

Fixes an example in the README where Debugf is configured to route to fmt.Printf, by using the splat operator to properly unpack format arguments.

Before

  • Format arguments not passed properly
  • No trailing new-line, hard to read
[send query] compression=["lz4" "((stripped))"] %!s(MISSING)[send data] compression=["lz4"][read data] compression=["lz4" '\x01' '\x00']. block: columns=%!d(MISSING), rows=%!d(MISSING)[read data] compression=["lz4" '\x01' '\x01']. block: columns=%!d(MISSING), rows=%!d(MISSING)[profile info] [rows=1, bytes=256, blocks=1, rows before limit=0, applied limit=false, calculated rows before limit=true][progress] [rows=83256135, bytes=83250374, total rows=83256135, wrote rows=0 wrote bytes=0 elapsed=10.628191ms][progress] [rows=83256135, bytes=83250374, total rows=83256135, wrote rows=0 wrote bytes=0 elapsed=10.628191ms][read data] compression=["lz4" '\x06' '0']. block: columns=%!d(MISSING), rows=%!d(MISSING)[profile events] rows=[48][read data] compression=["lz4" '\x00' '\x00']. block: columns=%!d(MISSING), rows=%!d(MISSING)[progress] [rows=0, bytes=0, total rows=0, wrote rows=0 wrote bytes=0 elapsed=137.047µs][progress] [rows=0, bytes=0, total rows=0, wrote rows=0 wrote bytes=0 elapsed=137.047µs][end of stream]%!(EXTRA []interface {}=[])

After

  • Format arguments passed properly
  • Trailing new-line, readable
[send query] compression="lz4" ((stripped))
[send data] compression="lz4"
[read data] compression="lz4". block: columns=1, rows=0
[read data] compression="lz4". block: columns=1, rows=1
[profile info] rows=1, bytes=256, blocks=1, rows before limit=0, applied limit=false, calculated rows before limit=true
[progress] rows=83256135, bytes=83250374, total rows=83256135, wrote rows=0 wrote bytes=0 elapsed=10.734099ms
[progress] rows=83256135, bytes=83250374, total rows=83256135, wrote rows=0 wrote bytes=0 elapsed=10.734099ms
[read data] compression="lz4". block: columns=6, rows=48
[profile events] rows=48
[read data] compression="lz4". block: columns=0, rows=0
[progress] rows=0, bytes=0, total rows=0, wrote rows=0 wrote bytes=0 elapsed=154.309µs
[progress] rows=0, bytes=0, total rows=0, wrote rows=0 wrote bytes=0 elapsed=154.309µs
[end of stream]

Checklist

Delete items not relevant to your PR:

@jkaflik jkaflik merged commit 40342ba into ClickHouse:main Dec 19, 2023
13 checks passed
@aramperes aramperes deleted the patch-1 branch December 19, 2023 11:24
mx-psi referenced this pull request in open-telemetry/opentelemetry-collector-contrib Jan 3, 2024
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
|
[github.com/ClickHouse/clickhouse-go/v2](https://github.com/ClickHouse/clickhouse-go)
| `v2.16.0` -> `v2.17.0` |
[![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fClickHouse%2fclickhouse-go%2fv2/v2.17.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fClickHouse%2fclickhouse-go%2fv2/v2.17.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fClickHouse%2fclickhouse-go%2fv2/v2.16.0/v2.17.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fClickHouse%2fclickhouse-go%2fv2/v2.16.0/v2.17.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>ClickHouse/clickhouse-go
(github.com/ClickHouse/clickhouse-go/v2)</summary>

###
[`v2.17.0`](https://github.com/ClickHouse/clickhouse-go/blob/HEAD/CHANGELOG.md#v2170-2023-12-21----Release-notes-generated-using-configuration-in-githubreleaseyml-at-main---)

[Compare
Source](https://github.com/ClickHouse/clickhouse-go/compare/v2.16.0...v2.17.0)

#### What's Changed

##### Enhancements 🎉

- Iterable ordered map alternative with improved performance by
[@&#8203;hanjm](https://github.com/hanjm) in
[https://github.com/ClickHouse/clickhouse-go/pull/1152](https://github.com/ClickHouse/clickhouse-go/pull/1152)
- Support bool alias type by
[@&#8203;yogasw](https://github.com/yogasw) in
[https://github.com/ClickHouse/clickhouse-go/pull/1156](https://github.com/ClickHouse/clickhouse-go/pull/1156)

##### Fixes 🐛

- Update README - mention HTTP protocol usable only with `database/sql`
interface by [@&#8203;jkaflik](https://github.com/jkaflik) in
[https://github.com/ClickHouse/clickhouse-go/pull/1160](https://github.com/ClickHouse/clickhouse-go/pull/1160)
- Fix README example for Debugf by
[@&#8203;aramperes](https://github.com/aramperes) in
[https://github.com/ClickHouse/clickhouse-go/pull/1153](https://github.com/ClickHouse/clickhouse-go/pull/1153)

#### New Contributors

- [@&#8203;yogasw](https://github.com/yogasw) made their first
contribution in
[https://github.com/ClickHouse/clickhouse-go/pull/1156](https://github.com/ClickHouse/clickhouse-go/pull/1156)
- [@&#8203;aramperes](https://github.com/aramperes) made their first
contribution in
[https://github.com/ClickHouse/clickhouse-go/pull/1153](https://github.com/ClickHouse/clickhouse-go/pull/1153)

**Full Changelog**:
ClickHouse/clickhouse-go@v2.16.0...v2.17.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any
time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/open-telemetry/opentelemetry-collector-contrib).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xMDMuMSIsInVwZGF0ZWRJblZlciI6IjM3LjEwMy4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: opentelemetrybot <[email protected]>
Co-authored-by: Bogdan Drutu <[email protected]>
cparkins referenced this pull request in AmadeusITGroup/opentelemetry-collector-contrib Jan 10, 2024
…-telemetry#30217)

[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
|
[github.com/ClickHouse/clickhouse-go/v2](https://github.com/ClickHouse/clickhouse-go)
| `v2.16.0` -> `v2.17.0` |
[![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fClickHouse%2fclickhouse-go%2fv2/v2.17.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fClickHouse%2fclickhouse-go%2fv2/v2.17.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fClickHouse%2fclickhouse-go%2fv2/v2.16.0/v2.17.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fClickHouse%2fclickhouse-go%2fv2/v2.16.0/v2.17.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>ClickHouse/clickhouse-go
(github.com/ClickHouse/clickhouse-go/v2)</summary>

###
[`v2.17.0`](https://github.com/ClickHouse/clickhouse-go/blob/HEAD/CHANGELOG.md#v2170-2023-12-21----Release-notes-generated-using-configuration-in-githubreleaseyml-at-main---)

[Compare
Source](https://github.com/ClickHouse/clickhouse-go/compare/v2.16.0...v2.17.0)

#### What's Changed

##### Enhancements 🎉

- Iterable ordered map alternative with improved performance by
[@&open-telemetry#8203;hanjm](https://github.com/hanjm) in
[https://github.com/ClickHouse/clickhouse-go/pull/1152](https://github.com/ClickHouse/clickhouse-go/pull/1152)
- Support bool alias type by
[@&open-telemetry#8203;yogasw](https://github.com/yogasw) in
[https://github.com/ClickHouse/clickhouse-go/pull/1156](https://github.com/ClickHouse/clickhouse-go/pull/1156)

##### Fixes 🐛

- Update README - mention HTTP protocol usable only with `database/sql`
interface by [@&open-telemetry#8203;jkaflik](https://github.com/jkaflik) in
[https://github.com/ClickHouse/clickhouse-go/pull/1160](https://github.com/ClickHouse/clickhouse-go/pull/1160)
- Fix README example for Debugf by
[@&open-telemetry#8203;aramperes](https://github.com/aramperes) in
[https://github.com/ClickHouse/clickhouse-go/pull/1153](https://github.com/ClickHouse/clickhouse-go/pull/1153)

#### New Contributors

- [@&open-telemetry#8203;yogasw](https://github.com/yogasw) made their first
contribution in
[https://github.com/ClickHouse/clickhouse-go/pull/1156](https://github.com/ClickHouse/clickhouse-go/pull/1156)
- [@&open-telemetry#8203;aramperes](https://github.com/aramperes) made their first
contribution in
[https://github.com/ClickHouse/clickhouse-go/pull/1153](https://github.com/ClickHouse/clickhouse-go/pull/1153)

**Full Changelog**:
ClickHouse/clickhouse-go@v2.16.0...v2.17.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any
time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/open-telemetry/opentelemetry-collector-contrib).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xMDMuMSIsInVwZGF0ZWRJblZlciI6IjM3LjEwMy4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: opentelemetrybot <[email protected]>
Co-authored-by: Bogdan Drutu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants