New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove incorrect usage of KeepAlive in DialContext #1009

Merged

jkaflik merged 1 commit into main from remove-keepalive-from-dialcontext

Jun 6, 2023

Contributor

jkaflik commented Jun 6, 2023 •

edited

Loading

Given the KeepAlive implementation comment:

	// KeepAlive specifies the interval between keep-alive
	// probes for an active network connection.
	// If zero, keep-alive probes are sent with a default value
	// (currently 15 seconds), if supported by the protocol and operating
	// system. Network protocols or operating systems that do
	// not support keep-alives ignore this field.
	// If negative, keep-alive probes are disabled.

having KeepAlive value set to opt.ConnMaxLifetime makes TCP connections broken.


          Remove incorrect usage of KeepAlive in DialContext

568401e

jkaflik added the bug label

jkaflik self-assigned this

jkaflik merged commit 6ba87b2 into main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug