Support client write info #221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Enmk
requested changes
Oct 14, 2022
den818
force-pushed
the
CLIENT_WRITE_INFO
branch
from
14857a0 to
72504b2
Compare
|
Server support CLIENT_WRITE_INFO since version 19.9 |
Test driver wouldn't crash if client hasn't received the progress
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to implement supporting query parameters. It requires raising the version of the protocol. The gap between the current server version of the protocol and the current client library version of the protocol is huge for one PR. So I decided to create several small PR and raise versions step by step.