New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make ItemView compatible with libcxx #166

Closed

itrofimow wants to merge 1 commit into ClickHouse:master from itrofimow:libcxx_string_view_fix

Contributor

itrofimow commented Mar 25, 2022

In libcxx version we currently use this constructor is deleted
basic_string_view(nullptr_t, size_t) = delete;

As of c++23 nullptr constructor is also deleted, and default constructor already does just that: .data = nullptr, .size = 0


          make ItemView compatible with libcxx

effe74b

itrofimow closed this

Contributor Author

itrofimow commented Mar 25, 2022

Closed in favor of #167 for checks restart ¯_(ツ)_/¯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet