Implement Append for ColumnTuple #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
I implemented Slice as well, this should now resolve #32 as well. |
Enmk
requested changes
Jan 8, 2022
clickhouse/columns/tuple.cpp
Outdated
| "to column type " + this->Type()->GetName()); | ||
| } | ||
| for (size_t ci = 0; ci < columns_.size(); ci++) { | ||
| columns_[ci]->Append((*column->As<ColumnTuple>())[ci]); |
There was a problem hiding this comment.
This case (with ->As<ColumnTuple>) should be moved outside for loop.
| @@ -22,7 +22,7 @@ class ColumnTuple : public Column { | |||
|
|
|||
| public: | |||
| /// Appends content of given column to the end of current one. | |||
| void Append(ColumnRef) override { } | |||
| void Append(ColumnRef column) override; | |||
There was a problem hiding this comment.
Please add some unit tests that validate implementation of ColumnTuple::Append(), both positive and negative cases.
| @@ -37,7 +37,7 @@ class ColumnTuple : public Column { | |||
| size_t Size() const override; | |||
|
|
|||
| /// Makes slice of the current column. | |||
| ColumnRef Slice(size_t, size_t) const override { return ColumnRef(); } | |||
| ColumnRef Slice(size_t, size_t) const override; | |||
There was a problem hiding this comment.
Please add some unit tests that validate implementation of ColumnTuple::Slice(), both positive and negative cases.
|
I added some unit tests for the append and slice case, I'm not quite sure what you mean with the negative case. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #115 and also adds the option to Append Tuples to
ColumnTuples.