Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow macOS builds to compile and run SSL tests #116

Merged
merged 3 commits into from
Jan 6, 2022
Merged

Allow macOS builds to compile and run SSL tests #116

merged 3 commits into from
Jan 6, 2022

Conversation

traceon
Copy link
Collaborator

@traceon traceon commented Nov 23, 2021

Assuming OpenSSL from Homebrew is installed.

@traceon traceon requested a review from Enmk November 23, 2021 23:09
Enmk
Enmk previously approved these changes Nov 26, 2021
View reviewed changes
Copy link
Collaborator

@Enmk Enmk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a workflow that runs the TLS-related tests on macOS.

@Enmk Enmk dismissed their stale review November 26, 2021 09:33

requires modifications

Enmk
Enmk requested changes Nov 26, 2021
View reviewed changes
Copy link
Collaborator

@Enmk Enmk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a workflow that runs the TLS-related tests on macOS.

@traceon
Copy link
Collaborator Author

traceon commented Nov 27, 2021 •
edited
Loading

I've added a similar workflow for macOS + TLS but, I guess, Client/* of tests won't run, since there is no server available for macOS workflows.

Also, probably need to merge this even with failed skipped workflows, and then fix re-run with a separate PR/on master, due to workflow reuse, which probably reference the master branch content:

Invalid workflow file : .github/workflows/macos_ssl.yml#L1
error parsing called workflow "ClickHouse/clickhouse-cpp/.github/workflows/macos.yml@master": workflow is not reusable as it is missing a `on.workflow_call` trigger

@Enmk Enmk merged commit 7697509 into master Jan 6, 2022
@Enmk Enmk deleted the traceon-patch-1 branch February 1, 2022 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Enmk Enmk Enmk requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@traceon @Enmk