Skip to content

Make all None by default arguments accept None value #450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 9, 2025
Merged

Make all None by default arguments accept None value #450

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions clickhouse_connect/driver/httputil.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,10 +55,10 @@ def close_managers():
def get_pool_manager_options(keep_interval: int = DEFAULT_KEEP_INTERVAL,
keep_count: int = DEFAULT_KEEP_COUNT,
keep_idle: int = DEFAULT_KEEP_IDLE,
ca_cert: str = None,
ca_cert: Optional[str] = None,
verify: bool = True,
client_cert: str = None,
client_cert_key: str = None,
client_cert: Optional[str] = None,
client_cert_key: Optional[str] = None,
**options) -> Dict[str, Any]:
socket_options = core_socket_options.copy()
if getattr(socket, 'TCP_KEEPINTVL', None) is not None:
Expand Down Expand Up @@ -88,12 +88,12 @@ def get_pool_manager_options(keep_interval: int = DEFAULT_KEEP_INTERVAL,
def get_pool_manager(keep_interval: int = DEFAULT_KEEP_INTERVAL,
keep_count: int = DEFAULT_KEEP_COUNT,
keep_idle: int = DEFAULT_KEEP_IDLE,
ca_cert: str = None,
ca_cert: Optional[str] = None,
verify: bool = True,
client_cert: str = None,
client_cert_key: str = None,
http_proxy: str = None,
https_proxy: str = None,
client_cert: Optional[str] = None,
client_cert_key: Optional[str] = None,
http_proxy: Optional[str] = None,
https_proxy: Optional[str] = None,
**options):
options = get_pool_manager_options(keep_interval,
keep_count,
Expand Down
Loading