Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix building issue introduced by https://github.com/ClickHouse-Extras… #10

Merged
merged 1 commit into from
Mar 21, 2022

Conversation

taiyang-li
Copy link

@taiyang-li taiyang-li commented Mar 8, 2022

fix building issue introduced by #9

@github-actions
Copy link

github-actions bot commented Mar 8, 2022

Thanks for opening a pull request!

If this is not a minor PR. Could you open an issue for this pull request on JIRA? https://issues.apache.org/jira/browse/ARROW

Opening JIRAs ahead of time contributes to the Openness of the Apache Arrow project.

Then could you also rename pull request title in the following format?

ARROW-${JIRA_ID}: [${COMPONENT}] ${SUMMARY}

or

MINOR: [${COMPONENT}] ${SUMMARY}

See also:

@taiyang-li
Copy link
Author

@Avogar Can you review this pr? Thank you in advance.

@Avogar
Copy link
Member

Avogar commented Mar 21, 2022

I don't have access to merge this PR(
Will find who can

@Avogar
Copy link
Member

Avogar commented Mar 21, 2022

Now I can merge it

@Avogar Avogar self-assigned this Mar 21, 2022
@Avogar Avogar merged commit 20dc6ad into ClickHouse:origin/release-6.0.1 Mar 21, 2022
@taiyang-li
Copy link
Author

@Avogar Thank you very much !

yaqi-zhao pushed a commit to yaqi-zhao/arrow_1 that referenced this pull request Aug 18, 2022
…ation (apache#13579)

When locally building the `conda-cpp-valgrind` docker image I've realised we are prompting for confirmation:

```
ClickHouse#10 12.35 Confirm changes: [Y/n] 
ClickHouse#10 88.01  
```
We should use the -y flag when using mamba install:
```
  -y, --yes             Do not ask for confirmation.
```
With this change we are no longer seeing the `Confirm changes` message from mamba.

Authored-by: Raúl Cumplido <[email protected]>
Signed-off-by: Sutou Kouhei <[email protected]>
nikitamikhaylov pushed a commit that referenced this pull request Oct 15, 2024
nikitamikhaylov added a commit that referenced this pull request Oct 16, 2024
* Empty commit

* Merge pull request #66 from copperybean/release-13.0.0

Check validation of of bit offset when reading bit packed values

(cherry picked from commit 5cfccd8)

* Merge pull request #47 from ClickHouse/fix-uninit-value-msan

Fix possible use-of-uninitizliaed-value

(cherry picked from commit ba5c679)

* Merge pull request #39 from ClickHouse/count-from-record-batch

Allow to get number of rows in record batch

(cherry picked from commit 1d93838)

* Merge pull request #9 from taiyang-li/raw_orc_reader

Add interface to get raw orc reader from adapters

(cherry picked from commit ce6b7af)

* Merge pull request #10 from taiyang-li/fix_pr_9

fix building issue introduced by https://github.com/ClickHouse-Extras…

(cherry picked from commit 20dc6ad)

* Merge pull request #14 from ClickHouse/fix-deadlock

Fix deadlock with msan

(cherry picked from commit b41ff44)

* Merge pull request #15 from ClickHouse/try-fix-data-race

Fix 'undefined symbol: pthread_atfork' on PowerPC64

(cherry picked from commit 450a563)

* Merge pull request #16 from ClickHouse/remove-abort-in-logging

Don't abort in ~CerrLog

(cherry picked from commit d03245f)

* Merge pull request #17 from bigo-sg/allow_map_key_optional

Allow Parquet map key to be optional

(cherry picked from commit 0d6d07f)

* Fix build

(cherry picked from commit 3264fda)

---------

Co-authored-by: Michael Kolupaev <[email protected]>
Co-authored-by: Kruglov Pavel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants