-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix handling of SSL_ERROR_WANT_READ/SSL_ERROR_WANT_WRITE
with zero timeout
#65941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robot-clickhouse
added
the
pr-bugfix
Pull request with bugfix, not backported by default
label
Jul 1, 2024
Contributor
This is an automated comment for commit ef24f51 with description of existing statuses. It's updated for the latest CI running ❌ Click here to open a full report in a separate page
Successful checks
|
…meout Previously if you were using socket without timeout it wasn't able to handle SSL_ERROR_WANT_READ/SSL_ERROR_WANT_WRITE, and even though sockets without timeouts is an odd thing (but it is possible - [1]), it still may be possible somewhere. [1]: ClickHouse#65917 Signed-off-by: Azat Khuzhin <[email protected]>
|
rschu1ze
changed the title
Fix handling of SSL_ERROR_WANT_READ/SSL_ERROR_WANT_WRITE with zero timeout
Fix handling of Jul 2, 2024
SSL_ERROR_WANT_READ/SSL_ERROR_WANT_WRITE
with zero timeout
rschu1ze
approved these changes
Jul 2, 2024
Merged
via the queue into
ClickHouse:master
with commit Jul 2, 2024
6fe8f33
240 of 248 checks passed
robot-ch-test-poll2
added
the
pr-synced-to-cloud
The PR is synced to the cloud repo
label
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
pr-bugfix
Pull request with bugfix, not backported by default
pr-synced-to-cloud
The PR is synced to the cloud repo
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, if you were using socket without timeout (timeout = 0), it wasn't able to handle
SSL_ERROR_WANT_READ
/SSL_ERROR_WANT_WRITE
, and even though sockets without timeouts is an odd thing (but still possible, (*)), it still may happen somewhere.(*): #65917
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fix handling of
SSL_ERROR_WANT_READ
/SSL_ERROR_WANT_WRITE
with zero timeout