-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Forbid QUALIFY clause in the old analyzer #65356
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
novikd
added
the
pr-must-backport
Pull request should be backported intentionally. Use this label with great care!
label
Jun 17, 2024
Contributor
This is an automated comment for commit 72e3fdc with description of existing statuses. It's updated for the latest CI running ❌ Click here to open a full report in a separate page
Successful checks
|
nickitat
reviewed
Jun 17, 2024
@@ -0,0 +1,11 @@ | |||
drop table if exists default.test_qualify; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it should be test database, otherwise concurrent execution will fail
nickitat
approved these changes
Jun 17, 2024
This was referenced Jun 19, 2024
robot-clickhouse
added a commit
that referenced
this pull request
Jun 19, 2024
This was referenced Jun 19, 2024
robot-clickhouse
added a commit
that referenced
this pull request
Jun 19, 2024
This was referenced Jun 19, 2024
robot-clickhouse
added a commit
that referenced
this pull request
Jun 19, 2024
robot-ch-test-poll1
added a commit
that referenced
this pull request
Jun 19, 2024
Backport #65356 to 24.4: Forbid QUALIFY clause in the old analyzer
robot-clickhouse-ci-2
added
the
pr-backports-created
Backport PRs are successfully created, it won't be processed by CI script anymore
label
Jun 19, 2024
novikd
added a commit
that referenced
this pull request
Jun 19, 2024
Backport #65356 to 24.5: Forbid QUALIFY clause in the old analyzer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
pr-backports-created
Backport PRs are successfully created, it won't be processed by CI script anymore
pr-backports-created-cloud
pr-critical-bugfix
pr-must-backport
Pull request should be backported intentionally. Use this label with great care!
pr-must-backport-cloud
pr-synced-to-cloud
The PR is synced to the cloud repo
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Forbid
QUALIFY
clause in the old analyzer. The old analyzer ignoredQUALIFY
, so it could lead to unexpected data removal in mutationsCloses #64596.
Documentation entry for user-facing changes
CI Settings (Only check the boxes if you know what you are doing):