Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unexpected projection name when query with CTE #65267

Conversation

wudidapaopao
Copy link
Contributor

@wudidapaopao wudidapaopao commented Jun 14, 2024

Fix #64504

Changelog category (leave one):

  • Bug Fix (user-visible misbehavior in an official stable release)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

  • Fix unexpected projection name when query with CTE

CTE should participate in names' collision resolution and be used for names' qualification.

  • Documentation is written (mandatory for new features)

Information about CI checks: https://clickhouse.com/docs/en/development/continuous-integration/

CI Settings (Only check the boxes if you know what you are doing):

  • Allow: All Required Checks
  • Allow: Stateless tests
  • Allow: Stateful tests
  • Allow: Integration Tests
  • Allow: Performance tests
  • Allow: Normal Builds
  • Allow: Special Builds
  • Allow: All NOT Required Checks
  • Allow: batch 1, 2 for multi-batch jobs
  • Allow: batch 3, 4, 5, 6 for multi-batch jobs

  • Exclude: Style check
  • Exclude: Fast test
  • Exclude: All with ASAN
  • Exclude: All with TSAN, MSAN, UBSAN, Coverage
  • Exclude: All with aarch64, release, debug

  • Do not test
  • Upload binaries for special builds
  • Disable merge-commit
  • Disable CI cache

@nikitamikhaylov nikitamikhaylov added the can be tested Allows running workflows for external contributors label Jun 14, 2024
@robot-ch-test-poll
Copy link
Contributor

robot-ch-test-poll commented Jun 14, 2024

This is an automated comment for commit 27d6b34 with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help❌ failure
Bugfix validationChecks that either a new test (functional or integration) or there some changed tests that fail with the binary built on master branch❌ failure
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests❌ failure
Successful checks
Check nameDescriptionStatus
BuildsThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
ClickBenchRuns [ClickBench](https://github.com/ClickHouse/ClickBench/) with instant-attach table✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker keeper imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docker server imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docs checkBuilds and tests the documentation✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integration tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors✅ success
Style checkRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts✅ success

@wudidapaopao wudidapaopao force-pushed the fix_unexpected_cte_projection_name branch from 54f61b6 to 7509ee6 Compare June 14, 2024 11:37
@robot-ch-test-poll2 robot-ch-test-poll2 added the pr-bugfix Pull request with bugfix, not backported by default label Jun 14, 2024
@wudidapaopao wudidapaopao force-pushed the fix_unexpected_cte_projection_name branch 4 times, most recently from 70c4e73 to f2b43b7 Compare June 15, 2024 11:31
@yakov-olkhovskiy yakov-olkhovskiy self-assigned this Jun 16, 2024
@Avogar
Copy link
Member

Avogar commented Jun 17, 2024

The test 03036_dynamic_read_subcolumns was failing in master. It's already fixed, so I updated branch with recent changes to avoid fails of this test in the CI.

@wudidapaopao wudidapaopao force-pushed the fix_unexpected_cte_projection_name branch from 5eb621d to cae2f02 Compare June 18, 2024 06:24
@yakov-olkhovskiy
Copy link
Member

@wudidapaopao we need this other way around - b.A expected for join b

@vdimir vdimir self-assigned this Jul 4, 2024
@yakov-olkhovskiy
Copy link
Member

@wudidapaopao I'm taking ownership of this PR - apparently some bugs surfaced and require more rigorous attention...

@yakov-olkhovskiy yakov-olkhovskiy added this pull request to the merge queue Jul 15, 2024
Merged via the queue into ClickHouse:master with commit 77396d0 Jul 15, 2024
238 of 246 checks passed
@robot-ch-test-poll3 robot-ch-test-poll3 added the pr-synced-to-cloud The PR is synced to the cloud repo label Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
can be tested Allows running workflows for external contributors pr-bugfix Pull request with bugfix, not backported by default pr-synced-to-cloud The PR is synced to the cloud repo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

inconsistent column names with analyzer and join of cte projections
8 participants