Fixing aliases for GLOBAL IN #64517

KochetovNicolai · 2024-05-28T14:45:11Z

Changelog category (leave one):

Bug Fix (user-visible misbehavior in an official stable release)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Fix the Expression nodes list expected 1 projection names and Unknown expression or identifier errors for queries with aliases to GLOBAL IN.

Fixes #64445

robot-ch-test-poll4 · 2024-05-28T14:47:08Z

This is an automated comment for commit 84d2bbc with description of existing statuses. It's updated for the latest CI running

⏳ Click here to open a full report in a separate page

Check name	Description	Status
CI running	A meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR	⏳ pending

Successful checks

Check name	Description	Status
A Sync	If it fails, ask a maintainer for help	✅ success
ClickHouse build check	Builds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process	✅ success
Docs check	Builds and tests the documentation	✅ success
Fast test	Normally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here	✅ success
Flaky tests	Checks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integration tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc	✅ success
Integration tests	The integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests	✅ success
Mergeable Check	Checks if all other necessary checks are successful	✅ success
PR Check	There's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS	✅ success
Stateful tests	Runs stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc	✅ success
Stateless tests	Runs stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc	✅ success
Style check	Runs a set of checks to keep the code style clean. If some of tests failed, see the related log from the report	✅ success
Unit tests	Runs the unit tests for different release types	✅ success

novikd

Please, add a test from the issue description.

src/Storages/buildQueryTreeForShard.cpp

novikd · 2024-05-29T08:34:53Z

src/Analyzer/Passes/QueryAnalysisPass.cpp

@@ -6566,7 +6578,8 @@ ProjectionNames QueryAnalyzer::resolveExpressionNode(QueryTreeNodePtr & node, Id
                    scope.scope_node->formatASTForErrorMessage());

            auto & table_node = node->as<TableNode &>();
-            result_projection_names.push_back(table_node.getStorageID().getFullNameNotQuoted());
+            if (result_projection_names.empty())


Just curious: when can it be non-empty?

In the scenario I saw, we can resolve identifier x alias y as TableNode (by alias), and in this case, at first, alias would be added to projection names, and then the storage name.

alexey-milovidov · 2024-05-29T21:49:32Z

Cloud does not use GLOBAL IN; backport still makes sense to simplify other backports.

KochetovNicolai · 2024-06-03T11:10:32Z

In stress tests, probably we stuck in distributed async inserts.

| | | | | | | | | | | | | | | | | | | | | | | | | | | 14   0x000000001c9aafdf in DB::DistributedAsyncInsertDirectoryQueue::run at /build/src/Storages/Distributed/DistributedAsyncInsertDirectoryQueue.cpp:200
| | | | | | | | | | | | | | | | | | | | | | | | | | | | 13   0x000000001c9aab26 in DB::DistributedAsyncInsertDirectoryQueue::processFiles at /build/src/Storages/Distributed/DistributedAsyncInsertDirectoryQueue.cpp:374
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | 12   0x000000001c9af031 in DB::DistributedAsyncInsertDirectoryQueue::processFile at /build/src/Storages/Distributed/DistributedAsyncInsertDirectoryQueue.cpp:430
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 12   0x000000001c9c1fe8 in DB::RemoteInserter::onFinish at /build/src/QueryPipeline/RemoteInserter.cpp:127
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 12   0x000000001d23ef4b in DB::Connection::receivePacket at /build/src/Client/Connection.cpp:1074
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 12   0x0000000012d7c0ac in DB::readVarUInt at /build/src/IO/VarInt.h:114
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 12   DB::varint_impl::readVarUInt<true> at /build/src/IO/VarInt.h:95
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 12   0x0000000012d7c34f in DB::ReadBuffer::eof at /build/src/IO/ReadBuffer.h:106
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 12   0x000000000afe6a0a in DB::ReadBuffer::next at /build/src/IO/ReadBuffer.h:70
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 12   0x0000000012f03b6a in DB::ReadBufferFromPocoSocket::nextImpl at /build/src/IO/ReadBufferFromPocoSocket.cpp:81
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 12   0x0000000022778ead in Poco::Net::SecureStreamSocketImpl::receiveBytes at /build/base/poco/NetSSL_OpenSSL/src/SecureStreamSocketImpl.cpp:139
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 12   0x00000000227752fd in Poco::Net::SecureSocketImpl::receiveBytes at /build/base/poco/NetSSL_OpenSSL/src/SecureSocketImpl.cpp:350
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 12   0x0000000022773e7f in Poco::Net::SecureSocketImpl::mustRetry at /build/base/poco/NetSSL_OpenSSL/src/SecureSocketImpl.cpp:480
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 12   0x00000000227b8b88 in Poco::Net::SocketImpl::pollImpl at /build/base/poco/Net/src/SocketImpl.cpp:436
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 12   0x00007fb0e76c8bcf in poll () from /lib/x86_64-linux-gnu/libc.so.6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | 1    0x000000001c9aef76 in DB::DistributedAsyncInsertDirectoryQueue::processFile at /build/src/Storages/Distributed/DistributedAsyncInsertDirectoryQueue.cpp:424
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 1    0x000000001c9c1918 in DB::RemoteInserter::RemoteInserter at /build/src/QueryPipeline/RemoteInserter.cpp:59
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 1    0x000000001d23ef4b in DB::Connection::receivePacket at /build/src/Client/Connection.cpp:1074
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 1    0x0000000012d7c0ac in DB::readVarUInt at /build/src/IO/VarInt.h:114
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 1    DB::varint_impl::readVarUInt<true> at /build/src/IO/VarInt.h:95
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 1    0x0000000012d7c34f in DB::ReadBuffer::eof at /build/src/IO/ReadBuffer.h:106
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 1    0x000000000afe6a0a in DB::ReadBuffer::next at /build/src/IO/ReadBuffer.h:70
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 1    0x0000000012f03b6a in DB::ReadBufferFromPocoSocket::nextImpl at /build/src/IO/ReadBufferFromPocoSocket.cpp:81
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 1    0x0000000022778ead in Poco::Net::SecureStreamSocketImpl::receiveBytes at /build/base/poco/NetSSL_OpenSSL/src/SecureStreamSocketImpl.cpp:139
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 1    0x00000000227752fd in Poco::Net::SecureSocketImpl::receiveBytes at /build/base/poco/NetSSL_OpenSSL/src/SecureSocketImpl.cpp:350
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 1    0x0000000022773e7f in Poco::Net::SecureSocketImpl::mustRetry at /build/base/poco/NetSSL_OpenSSL/src/SecureSocketImpl.cpp:480
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 1    0x00000000227b8b88 in Poco::Net::SocketImpl::pollImpl at /build/base/poco/Net/src/SocketImpl.cpp:436
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 1    0x00007fb0e76c8bcf in poll () from /lib/x86_64-linux-gnu/libc.so.6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | 1    0x000000001c9aabbc in DB::DistributedAsyncInsertDirectoryQueue::processFiles at /build/src/Storages/Distributed/DistributedAsyncInsertDirectoryQueue.cpp:377
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | 1    0x000000001c9af031 in DB::DistributedAsyncInsertDirectoryQueue::processFile at /build/src/Storages/Distributed/DistributedAsyncInsertDirectoryQueue.cpp:430
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 1    0x000000001c9c1fe8 in DB::RemoteInserter::onFinish at /build/src/QueryPipeline/RemoteInserter.cpp:127
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 1    0x000000001d23ef4b in DB::Connection::receivePacket at /build/src/Client/Connection.cpp:1074
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 1    0x0000000012d7c0ac in DB::readVarUInt at /build/src/IO/VarInt.h:114
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 1    DB::varint_impl::readVarUInt<true> at /build/src/IO/VarInt.h:95
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 1    0x0000000012d7c34f in DB::ReadBuffer::eof at /build/src/IO/ReadBuffer.h:106
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 1    0x000000000afe6a0a in DB::ReadBuffer::next at /build/src/IO/ReadBuffer.h:70
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 1    0x0000000012f03b6a in DB::ReadBufferFromPocoSocket::nextImpl at /build/src/IO/ReadBufferFromPocoSocket.cpp:81
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 1    0x0000000022778ead in Poco::Net::SecureStreamSocketImpl::receiveBytes at /build/base/poco/NetSSL_OpenSSL/src/SecureStreamSocketImpl.cpp:139
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 1    0x00000000227752fd in Poco::Net::SecureSocketImpl::receiveBytes at /build/base/poco/NetSSL_OpenSSL/src/SecureSocketImpl.cpp:350
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 1    0x0000000022773e7f in Poco::Net::SecureSocketImpl::mustRetry at /build/base/poco/NetSSL_OpenSSL/src/SecureSocketImpl.cpp:480
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 1    0x00000000227b8b88 in Poco::Net::SocketImpl::pollImpl at /build/base/poco/Net/src/SocketImpl.cpp:436
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 1    0x00007fb0e76c8bcf in poll () from /lib/x86_64-linux-gnu/libc.so.6

…e5fcfb2013eabcf38be007840acdd Cherry pick #64517 to 24.4: Fixing aliases for GLOBAL IN

…e5fcfb2013eabcf38be007840acdd Cherry pick #64517 to 24.5: Fixing aliases for GLOBAL IN

Backport #64517 to 24.5: Fixing aliases for GLOBAL IN

Backport #64517 to 24.4: Fixing aliases for GLOBAL IN

…e5fcfb2013eabcf38be007840acdd Cherry pick #64517 to 24.3: Fixing aliases for GLOBAL IN

Fixing aliases for GLOBAL IN

506bc44

KochetovNicolai added pr-must-backport Pull request should be backported intentionally. Use this label with great care! pr-must-backport-cloud analyzer Issues and pull-requests related to new analyzer labels May 28, 2024

robot-ch-test-poll4 added the pr-bugfix Pull request with bugfix, not backported by default label May 28, 2024

novikd self-assigned this May 28, 2024

novikd reviewed May 28, 2024

View reviewed changes

src/Storages/buildQueryTreeForShard.cpp Outdated Show resolved Hide resolved

KochetovNicolai added 3 commits May 28, 2024 15:47

Add tests

c09b377

Review fixes.

1e15be9

Add tests

d22c971

novikd approved these changes May 29, 2024

View reviewed changes

KochetovNicolai added 5 commits May 29, 2024 10:54

Merge branch 'master' into fix-some-aliases-for-global-in

9a8efdf

Another try.

dd0f85d

Another attempt.

d2c2fa9

Cleanup.

c23b92b

Fix another test.

278d336

alexey-milovidov added pr-must-backport-cloud and removed pr-must-backport-cloud labels May 29, 2024

Update 03164_analyzer_global_in_alias.sql

fb9402a

KochetovNicolai added this pull request to the merge queue May 31, 2024

github-merge-queue bot removed this pull request from the merge queue due to no response for status checks May 31, 2024

KochetovNicolai enabled auto-merge June 3, 2024 11:10

Merge branch 'master' into fix-some-aliases-for-global-in

84d2bbc

KochetovNicolai added this pull request to the merge queue Jun 3, 2024

Merged via the queue into master with commit 49043d4 Jun 3, 2024
75 of 83 checks passed

KochetovNicolai deleted the fix-some-aliases-for-global-in branch June 3, 2024 13:30

robot-ch-test-poll4 added the pr-synced-to-cloud The PR is synced to the cloud repo label Jun 3, 2024

robot-ch-test-poll added the pr-backports-created-cloud label Jun 3, 2024

robot-ch-test-poll4 added the pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore label Jun 3, 2024

Felixoid removed pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore pr-backports-created-cloud labels Jun 7, 2024

robot-ch-test-poll3 added the pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore label Jun 7, 2024

maxknv removed the pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore label Jun 8, 2024

robot-clickhouse-ci-2 added the pr-backports-created-cloud label Jun 8, 2024

robot-ch-test-poll4 added a commit that referenced this pull request Jun 10, 2024

Merge pull request #64751 from ClickHouse/cherrypick/24.4/49043d43996…

26559c3

…e5fcfb2013eabcf38be007840acdd Cherry pick #64517 to 24.4: Fixing aliases for GLOBAL IN

robot-clickhouse added a commit that referenced this pull request Jun 10, 2024

Backport #64517 to 24.4: Fixing aliases for GLOBAL IN

db22326

robot-ch-test-poll4 mentioned this pull request Jun 10, 2024

Backport #64517 to 24.4: Fixing aliases for GLOBAL IN #65060

Merged

robot-ch-test-poll4 added a commit that referenced this pull request Jun 10, 2024

Merge pull request #64752 from ClickHouse/cherrypick/24.5/49043d43996…

f9975b5

…e5fcfb2013eabcf38be007840acdd Cherry pick #64517 to 24.5: Fixing aliases for GLOBAL IN

robot-clickhouse added a commit that referenced this pull request Jun 10, 2024

Backport #64517 to 24.5: Fixing aliases for GLOBAL IN

73370fe

robot-ch-test-poll4 mentioned this pull request Jun 10, 2024

Backport #64517 to 24.5: Fixing aliases for GLOBAL IN #65061

Merged

robot-ch-test-poll4 added the pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore label Jun 10, 2024

robot-ch-test-poll4 added a commit that referenced this pull request Jun 10, 2024

Merge pull request #65061 from ClickHouse/backport/24.5/64517

aea9a94

Backport #64517 to 24.5: Fixing aliases for GLOBAL IN

maxknv removed pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore pr-backports-created-cloud labels Jun 12, 2024

robot-clickhouse added the pr-backports-created-cloud label Jun 12, 2024

novikd added a commit that referenced this pull request Jun 27, 2024

Merge pull request #65060 from ClickHouse/backport/24.4/64517

2a13c64

Backport #64517 to 24.4: Fixing aliases for GLOBAL IN

robot-ch-test-poll added a commit that referenced this pull request Jun 27, 2024

Merge pull request #64750 from ClickHouse/cherrypick/24.3/49043d43996…

b76e944

…e5fcfb2013eabcf38be007840acdd Cherry pick #64517 to 24.3: Fixing aliases for GLOBAL IN

robot-clickhouse added a commit that referenced this pull request Jun 27, 2024

Backport #64517 to 24.3: Fixing aliases for GLOBAL IN

951ed7c

robot-ch-test-poll mentioned this pull request Jun 27, 2024

Backport #64517 to 24.3: Fixing aliases for GLOBAL IN #65755

Open

robot-ch-test-poll3 added the pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore label Jun 27, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixing aliases for GLOBAL IN #64517

Fixing aliases for GLOBAL IN #64517

KochetovNicolai commented May 28, 2024 •

edited by Algunenano

Loading

robot-ch-test-poll4 commented May 28, 2024 •

edited by robot-ch-test-poll2

Loading

novikd left a comment

novikd May 29, 2024

KochetovNicolai May 29, 2024

alexey-milovidov commented May 29, 2024

KochetovNicolai commented Jun 3, 2024

Fixing aliases for GLOBAL IN #64517

Fixing aliases for GLOBAL IN #64517

Conversation

KochetovNicolai commented May 28, 2024 • edited by Algunenano Loading

Changelog category (leave one):

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

robot-ch-test-poll4 commented May 28, 2024 • edited by robot-ch-test-poll2 Loading

novikd left a comment

Choose a reason for hiding this comment

novikd May 29, 2024

Choose a reason for hiding this comment

KochetovNicolai May 29, 2024

Choose a reason for hiding this comment

alexey-milovidov commented May 29, 2024

KochetovNicolai commented Jun 3, 2024

KochetovNicolai commented May 28, 2024 •

edited by Algunenano

Loading

robot-ch-test-poll4 commented May 28, 2024 •

edited by robot-ch-test-poll2

Loading