Fix 'set' skip index not working with IN, indexHint(), and subqueries

[al13n321]

Changelog category (leave one):

• Bug Fix (user-visible misbehavior in an official stable release)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Fixed 'set' skip index not working with IN and indexHint()

Example:

create table a (k UInt64, v UInt64, index i (v) type set(100) granularity 2) engine MergeTree order by k;
insert into a select number, intDiv(number, 4096) from numbers(1000000);
select sum(1+ignore(*)) from a where indexHint(v in (20, 40));

Without the fix it outputs 1000000 (i.e. reads all 1M rows), with the fix 32768 (i.e. reads 4 granules, as expected).

Also works with subqueries now:

select sum(1+ignore(*)) from a where indexHint(v in (select 20 union all select 40));

• The IN thing got broken by Analyzer: Correctly handle constant set in index #58657 - it (inadvertently?) disabled the index if the expression contains a constant set.
• indexHint() got broken some time before that.
• Subqueries were probably never supported.

[robot-clickhouse-ci-1]

This is an automated comment for commit c22a4b7 with description of existing statuses. It's updated for the latest CI running

⏳ Click here to open a full report in a separate page

Check name	Description	Status
CI running	A meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR	⏳ pending

Successful checks

Check name	Description	Status
A Sync	If it fails, ask a maintainer for help	✅ success
ClickHouse build check	Builds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process	✅ success
Docs check	Builds and tests the documentation	✅ success
Fast test	Normally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here	✅ success
Flaky tests	Checks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integration tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc	✅ success
Mergeable Check	Checks if all other necessary checks are successful	✅ success
PR Check	There's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS	✅ success
Stateful tests	Runs stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc	✅ success
Stateless tests	Runs stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc	✅ success
Style check	Runs a set of checks to keep the code style clean. If some of tests failed, see the related log from the report	✅ success
Unit tests	Runs the unit tests for different release types	✅ success

[jkartseva]

Will the node pointers copied to store remain valid after actions are passed to mergeNodes?
Okay, the function does not modify the pointers so should be fine.

[alexey-milovidov]

@al13n321, fuzzers have found a lot of errors.

[al13n321]

The failed test is unrelated (SELECT * FROM loop('', '') crashes the server - candidate for the shortest query that does that :) ).

EDIT: #64716

[DerekChia]

@al13n321 possible to backport at least to 24.3 LTS? It's been broken for a while - #65141