Fix_kql_issue_found_by_wingfuzz #59626

kashwy · 2024-02-06T06:57:51Z

Changelog category (leave one):

Bug Fix (user-visible misbehavior in an official stable release)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Fix segmentation fault in KQL parser when the input query exceeds the max_query_size. Also re-enable the KQL dialect. Fixes #59036 and #59037.

This commit fixes the issues:
#59036
#59037

both issues are same reason, the input query exceed the max_query_size, so the condition isEnd() of token is not meet and cause the assertion failure

This commit fix the issues: ClickHouse#59036 ClickHouse#59037 both issues are same reason, the input query exceed the max_query_size, so the condition isEnd() of token is not meet and cause the assertion failure

robot-ch-test-poll4 · 2024-02-06T10:10:16Z

This is an automated comment for commit 69b9547 with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Successful checks

Check name	Description	Status
A Sync	There's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS	✅ success
Bugfix validation	Checks that either a new test (functional or integration) or there some changed tests that fail with the binary built on master branch	✅ success
ClickBench	Runs [ClickBench](https://github.com/ClickHouse/ClickBench/) with instant-attach table	✅ success
ClickHouse build check	Builds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process	✅ success
Compatibility check	Checks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help	✅ success
Docker keeper image	The check to build and optionally push the mentioned image to docker hub	✅ success
Docker server image	The check to build and optionally push the mentioned image to docker hub	✅ success
Docs check	Builds and tests the documentation	✅ success
Fast test	Normally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here	✅ success
Flaky tests	Checks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc	✅ success
Install packages	Checks that the built packages are installable in a clear environment	✅ success
Mergeable Check	Checks if all other necessary checks are successful	✅ success
Performance Comparison	Measure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests	✅ success
SQLTest	There's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS	✅ success
SQLancer	Fuzzing tests that detect logical bugs with SQLancer tool	✅ success
Sqllogic	Run clickhouse on the sqllogic test set against sqlite and checks that all statements are passed	✅ success
Stateful tests	Runs stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc	✅ success
Style check	Runs a set of checks to keep the code style clean. If some of tests failed, see the related log from the report	✅ success
Unit tests	Runs the unit tests for different release types	✅ success

Check name	Description	Status
AST fuzzer	Runs randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help	❌ failure
BuilderBinClangTidy / Build-binary_tidy	There's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS	⏳ pending
BuilderBinClangTidy	There's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS	⏳ pending
CI running	A meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR	⏳ pending
Integration tests	The integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests	❌ failure
PullRequestCI / BuilderBinClangTidy / Build-binary_tidy (pull_request)	There's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS	⏳ pending
PullRequestCI / BuilderBinClangTidy / Build-binary_tidy	There's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS	⏳ pending
Stateless tests	Runs stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc	❌ failure
Stress test	Runs stateless functional tests concurrently from several clients to detect concurrency-related errors	❌ failure
Upgrade check	Runs stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts	❌ failure

antaljanosbenjamin

Apart from these small changes I think the PR looks fine. I haven't checked the tests throrougly, but I assume it is coming from a good source and/or validated with other KQL parsers.

src/Parsers/Kusto/ParserKQLQuery.cpp

…dOfStream

antaljanosbenjamin · 2024-02-06T14:33:34Z

I edited the PR description to hopefully make the PR check happy.

kashwy · 2024-02-06T14:35:21Z

I edited the PR description to hopefully make the PR check happy.

thanks

yakov-olkhovskiy · 2024-02-06T14:49:04Z

I think we also need test for this bug

kashwy · 2024-02-06T20:27:16Z

I think we also need test for this bug

this can be tested manually without "--multiquery", otherwise the ErrorMaxQuerySizeExceeded is not triggered

can do WING Fuzz test to see if the bug is fixed or not

kashwy · 2024-02-07T16:30:19Z

Hi @antaljanosbenjamin , can you do the Wing Fuzz test to verify the issue:

#59036
#59037

thanks

test result of 02366_kql_makeseries and 02366_kql_extend show failed because they have random row order, the results are correct

antaljanosbenjamin · 2024-02-08T10:00:54Z

I can try to check the wingfuzz tests, but it is not clear to me how to reproduce the issue. I have also other tasks, so it might take some time.

In the meantime, I think the failing KQL test should be fixed. If the row order is random, we should either remove the test or make the row order deterministic.

kashwy · 2024-02-11T02:13:48Z

I can try to check the wingfuzz tests, but it is not clear to me how to reproduce the issue. I have also other tasks, so it might take some time.

In the meantime, I think the failing KQL test should be fixed. If the row order is random, we should either remove the test or make the row order deterministic.

yes, I have the test result updated.
for the wingfuzz tests, I think there is deadline for it, can you do it ASAP ?
thanks

kashwy · 2024-02-12T14:02:28Z

@antaljanosbenjamin, the failures are not related with this PR now

kashwy · 2024-02-13T06:23:50Z

@antaljanosbenjamin
is there any news about the WING Fuzz test?

Best Regards

alexey-milovidov · 2024-02-13T18:48:24Z

src/Parsers/Kusto/ParserKQLQuery.cpp

@@ -373,9 +373,9 @@ bool ParserKQLQuery::parseImpl(Pos & pos, ASTPtr & node, Expected & expected)

    uint16_t bracket_count = 0;

-    while ((pos->type < TokenType::EndOfStream ||


Ok, but it works exactly the same.

before we use pos->isEnd() to validate, but when reach max_query_size, the iterator already passed the end

The code looks the same: bool isValid() { return get().type < TokenType::EndOfStream; }

oh, yes, changed according to @antaljanosbenjamin 's suggestion

Because pos->isEnd() would be false in case of TokenType::ErrorMaxQuerySizeExceeded, thus !pos->isEnd() wouldn't terminate the loop. Meanwhile pos->isValid() will be false in case of TokenType::ErrorMaxQuerySizeExceeded, thus stopping the loop. Do I miss something?

alexey-milovidov · 2024-02-15T04:29:26Z

Do you mean that the makeseries function contains a bug? Then, we should remove or fix it.

antaljanosbenjamin · 2024-02-15T10:51:21Z

Do you mean that the makeseries function contains a bug? Then, we should remove or fix it.

Actually this might a general issue in KQL parsers. If I search for isEnd() in src/Parsers most of the matches are KQL parsers:

 grep -Rnwl './src/Parsers' -e 'isEnd()'
./src/Parsers/parseQuery.cpp
./src/Parsers/examples/lexer.cpp
./src/Parsers/Kusto/ParserKQLMakeSeries.cpp
./src/Parsers/Kusto/ParserKQLMVExpand.cpp
./src/Parsers/Kusto/parseKQLQuery.cpp
./src/Parsers/Kusto/ParserKQLSort.cpp
./src/Parsers/Kusto/ParserKQLStatement.cpp
./src/Parsers/Kusto/ParserKQLOperators.cpp
./src/Parsers/Kusto/ParserKQLExtend.cpp
./src/Parsers/Kusto/ParserKQLSummarize.cpp
./src/Parsers/Kusto/KustoFunctions/KQLDateTimeFunctions.cpp
./src/Parsers/Kusto/KustoFunctions/KQLDataTypeFunctions.cpp
./src/Parsers/Kusto/KustoFunctions/KQLStringFunctions.cpp
./src/Parsers/Kusto/KustoFunctions/IParserKQLFunction.cpp
./src/Parsers/Kusto/ParserKQLQuery.cpp
./src/Parsers/PRQL/ParserPRQLQuery.cpp
./src/Parsers/toOneLineQuery.cpp
./src/Parsers/Lexer.h
./src/Parsers/TokenIterator.cpp
./src/Parsers/queryNormalization.cpp
./src/Parsers/obfuscateQueries.cpp
./src/Parsers/fuzzers/lexer_fuzzer.cpp

This might mean that all of these checks in Kusto has to be addresssed:

grep -Rnw './src/Parsers/Kusto' -e 'isEnd()'
./src/Parsers/Kusto/ParserKQLMakeSeries.cpp:42:    while (!pos->isEnd() && pos->type != TokenType::PipeMark && pos->type != TokenType::Semicolon)
./src/Parsers/Kusto/ParserKQLMakeSeries.cpp:99:    while (!pos->isEnd() && pos->type != TokenType::PipeMark && pos->type != TokenType::Semicolon)
./src/Parsers/Kusto/ParserKQLMakeSeries.cpp:178:        while (!pos->isEnd())
./src/Parsers/Kusto/ParserKQLMakeSeries.cpp:204:        while (!pos->isEnd())
./src/Parsers/Kusto/ParserKQLMVExpand.cpp:52:    while (!pos->isEnd() && pos->type != TokenType::PipeMark && pos->type != TokenType::Semicolon)
./src/Parsers/Kusto/ParserKQLMVExpand.cpp:128:        if (!pos->isEnd())
./src/Parsers/Kusto/ParserKQLMVExpand.cpp:130:        if (pos->isEnd() || pos->type == TokenType::PipeMark || pos->type == TokenType::Semicolon)
./src/Parsers/Kusto/parseKQLQuery.cpp:250:    for (TokenIterator it = begin; !it->isEnd(); ++it)
./src/Parsers/Kusto/parseKQLQuery.cpp:332:    if (token_iterator->isEnd()
./src/Parsers/Kusto/parseKQLQuery.cpp:406:    if (!token_iterator->isEnd()
./src/Parsers/Kusto/parseKQLQuery.cpp:424:        && !token_iterator->isEnd())
./src/Parsers/Kusto/ParserKQLSort.cpp:27:    while (!new_pos->isEnd() && new_pos->type != TokenType::PipeMark && new_pos->type != TokenType::Semicolon)
./src/Parsers/Kusto/ParserKQLStatement.cpp:82:            while (!pos->isEnd())
./src/Parsers/Kusto/ParserKQLOperators.cpp:151:    while (!token_pos->isEnd() && token_pos->type != TokenType::PipeMark && token_pos->type != TokenType::Semicolon)
./src/Parsers/Kusto/ParserKQLOperators.cpp:220:    while (!token_pos->isEnd() && token_pos->type != DB::TokenType::PipeMark && token_pos->type != DB::TokenType::Semicolon)
./src/Parsers/Kusto/ParserKQLOperators.cpp:332:    if (!pos->isEnd() && pos->type != TokenType::PipeMark && pos->type != TokenType::Semicolon)
./src/Parsers/Kusto/ParserKQLOperators.cpp:342:            if (pos->isEnd() || pos->type == TokenType::PipeMark || pos->type == TokenType::Semicolon)
./src/Parsers/Kusto/ParserKQLOperators.cpp:349:            if (!pos->isEnd() && pos->type != TokenType::PipeMark && pos->type != TokenType::Semicolon)
./src/Parsers/Kusto/ParserKQLOperators.cpp:363:        if (!pos->isEnd() && pos->type != TokenType::PipeMark && pos->type != TokenType::Semicolon)
./src/Parsers/Kusto/ParserKQLExtend.cpp:47:    while (!npos->isEnd())
./src/Parsers/Kusto/ParserKQLSummarize.cpp:123:                if (equal_pos->isEnd() || equal_pos->type == TokenType::Comma || equal_pos->type == TokenType::Semicolon
./src/Parsers/Kusto/ParserKQLSummarize.cpp:154:    while (!pos->isEnd() && pos->type != TokenType::PipeMark && pos->type != TokenType::Semicolon)
./src/Parsers/Kusto/KustoFunctions/KQLDateTimeFunctions.cpp:524:    while (!pos->isEnd() && pos->type != TokenType::ClosingRoundBracket)
./src/Parsers/Kusto/KustoFunctions/KQLDateTimeFunctions.cpp:591:    while (!pos->isEnd() && pos->type != TokenType::ClosingRoundBracket)
./src/Parsers/Kusto/KustoFunctions/KQLDataTypeFunctions.cpp:54:        while (!pos->isEnd() && pos->type != TokenType::PipeMark && pos->type != TokenType::Semicolon)
./src/Parsers/Kusto/KustoFunctions/KQLDataTypeFunctions.cpp:80:    while (!pos->isEnd() && pos->type != TokenType::ClosingRoundBracket)
./src/Parsers/Kusto/KustoFunctions/KQLDataTypeFunctions.cpp:120:        while (!pos->isEnd() && pos->type != TokenType::PipeMark && pos->type != TokenType::Semicolon)
./src/Parsers/Kusto/KustoFunctions/KQLStringFunctions.cpp:593:    while (!pos->isEnd() && pos->type != TokenType::Semicolon && pos->type != TokenType::ClosingRoundBracket)
./src/Parsers/Kusto/KustoFunctions/IParserKQLFunction.cpp:76:    while (!pos->isEnd() && pos->type != TokenType::PipeMark && pos->type != TokenType::Semicolon)
./src/Parsers/Kusto/KustoFunctions/IParserKQLFunction.cpp:151:    if (pos->isEnd() || pos->type == TokenType::PipeMark || pos->type == TokenType::Semicolon)
./src/Parsers/Kusto/KustoFunctions/IParserKQLFunction.cpp:155:    while (!pos->isEnd() && pos->type != TokenType::PipeMark && pos->type != TokenType::Semicolon)
./src/Parsers/Kusto/KustoFunctions/IParserKQLFunction.cpp:194:                    while (!pos->isEnd() && pos->type != TokenType::ClosingSquareBracket)
./src/Parsers/Kusto/KustoFunctions/IParserKQLFunction.cpp:249:    while (!pos->isEnd() && (!scopes.empty() || (pos->type != DB::TokenType::Comma && pos->type != DB::TokenType::ClosingRoundBracket)))
./src/Parsers/Kusto/KustoFunctions/IParserKQLFunction.cpp:360:        while (!pos->isEnd() && pos->type != TokenType::ClosingSquareBracket)
./src/Parsers/Kusto/ParserKQLQuery.cpp:133:    while (!end->isEnd() && end->type != TokenType::Semicolon)
./src/Parsers/Kusto/ParserKQLQuery.cpp:152:    while (!pos->isEnd() && pos->type != TokenType::Semicolon)
./src/Parsers/Kusto/ParserKQLQuery.cpp:376:    while (!pos->isEnd() && pos->type != TokenType::Semicolon)

I am not sure, but it is suspicious. I will try to play with them and find new bugs.

antaljanosbenjamin · 2024-02-15T10:52:30Z

@kashwy if you want to help, you can also check out what happend when some of these isEnd() checks encounters TokenType::ErrorMaxQuerySizeExceeded.

kashwy · 2024-02-15T14:07:03Z

Do you mean that the makeseries function contains a bug? Then, we should remove or fix it.

it generate result of row in random order, will fixed with a separated PR

kashwy · 2024-02-15T14:11:32Z

@kashwy if you want to help, you can also check out what happend when some of these isEnd() checks encounters TokenType::ErrorMaxQuerySizeExceeded.

I can change all of them, although TokenType::ErrorMaxQuerySizeExceeded. will be screened out at the first place

antaljanosbenjamin · 2024-02-15T15:45:58Z

I can change all of them, although TokenType::ErrorMaxQuerySizeExceeded. will be screened out at the first place

I miss something in the logic then. Could you please clarify?

kashwy · 2024-02-15T15:51:23Z

I can change all of them, although TokenType::ErrorMaxQuerySizeExceeded. will be screened out at the first place

I miss something in the logic then. Could you please clarify?

sure.
the current change is the entry point of kql parsing , if encountered TokenType::ErrorMaxQuerySizeExceeded, it will throw exception, and will not go to other parser

antaljanosbenjamin · 2024-02-15T16:52:53Z

the current change is the entry point of kql parsing , if encountered TokenType::ErrorMaxQuerySizeExceeded, it will throw exception, and will not go to other parser

But what if other parsers are started to parse a portion of the query? E.g.:

$ cat query.txt
SET dialect = 'kusto';
SET max_query_size = 16;
Customers | where Education contains 'degree'
$ ./clickhouse_fixed -n < query.txt 
Code: 1001. DB::Exception: std::bad_alloc: std::bad_alloc. (STD_EXCEPTION)

I think what happens here is:

Customers is parsed as a table operator => everything is fine
A ParserKQLFilter starts to parse the Education contains 'degree' part. In this part the query size limit is reached in 'degree', so there will be the TokenType::ErrorMaxQuerySizeExceeded, however ParserKQLBase :: getExprFromToken only checks !pos->isEnd(), this it passes the end of the string and we end up with a huuuuuuge string, that is why std::bad_alloc is thrown.

But there is another example:

$ cat query.txt
SET dialect = 'kusto';
SET max_query_size = 44;
Customers | where Education contains 'degree' | order by LastName
$ ./clickhouse_fixed -n < query.txt 
Code: 1001. DB::Exception: std::length_error: basic_string. (STD_EXCEPTION)

Here the same thing happens, but with ParserKQLSort. If you use the debug builds, it is obvious that this is wrong:

$ cat query.txt
SET dialect = 'kusto';
SET max_query_size = 44;
Customers | where Education contains 'degree' | order by LastName
$ ./clickhouse_fixed_debug -n < query.txt 
clickhouse_fixed_debug: /build/src/Parsers/TokenIterator.h:31: const Token &DB::Tokens::operator[](size_t): Assertion `index < data.size()' failed.
Aborted (core dumped)

I think this needs to be fixed. All of the isEnd() calls in KQL parsers are potential issues.

(BTW: I just realized that Alexey's comment is about the tests, but it directed my focus and I think we ended up with a better result).

kashwy · 2024-02-15T16:55:09Z

the current change is the entry point of kql parsing , if encountered TokenType::ErrorMaxQuerySizeExceeded, it will throw exception, and will not go to other parser

But what if other parsers are started to parse a portion of the query? E.g.:
$ cat query.txt
SET dialect = 'kusto';
SET max_query_size = 16;
Customers | where Education contains 'degree'
$ ./clickhouse_fixed -n < query.txt 
Code: 1001. DB::Exception: std::bad_alloc: std::bad_alloc. (STD_EXCEPTION)
I think what happens here is:

Customers is parsed as a table operator => everything is fine

A ParserKQLFilter starts to parse the Education contains 'degree' part. In this part the query size limit is reached in 'degree', so there will be the TokenType::ErrorMaxQuerySizeExceeded, however ParserKQLBase :: getExprFromToken only checks !pos->isEnd(), this it passes the end of the string and we end up with a huuuuuuge string, that is why std::bad_alloc is thrown.

But there is another example:
$ cat query.txt
SET dialect = 'kusto';
SET max_query_size = 44;
Customers | where Education contains 'degree' | order by LastName
$ ./clickhouse_fixed -n < query.txt 
Code: 1001. DB::Exception: std::length_error: basic_string. (STD_EXCEPTION)
Here the same thing happens, but with ParserKQLSort. If you use the debug builds, it is obvious that this is wrong:
$ cat query.txt
SET dialect = 'kusto';
SET max_query_size = 44;
Customers | where Education contains 'degree' | order by LastName
$ ./clickhouse_fixed_debug -n < query.txt 
clickhouse_fixed_debug: /build/src/Parsers/TokenIterator.h:31: const Token &DB::Tokens::operator[](size_t): Assertion `index < data.size()' failed.
Aborted (core dumped)
I think this needs to be fixed. All of the isEnd() calls in KQL parsers are potential issues.

(BTW: I just realized that Alexey's comment is about the tests, but it directed my focus and I think we ended up with a better result).

sure, I am fixing it

…_by_wingfuzz

kashwy · 2024-02-22T02:46:05Z

So the issue is we recently made some changes in master in order to enforce that queries are formatted and parsed properly. That caused a lot of noise in our CI. As this PR is related to parsers, I will merge a recent master to rerun the tests. So far I haven't seen anything KQL related, but I might be wrong because of the huge number of failed tests I haven't checked every test in details.

thank you very much. I did not see errors related with kql.
Can this PR be merged ?

Best regard

antaljanosbenjamin · 2024-02-22T11:28:36Z

I have rerun the clang-tidy build, because that is required check. After that I think the PR can be merged.

kashwy · 2024-02-22T14:13:35Z

I have rerun the clang-tidy build, because that is required check. After that I think the PR can be merged.

thanks

antaljanosbenjamin · 2024-02-26T10:13:57Z

Test failures:

Stress Test (ubsan) Logical error: Invalid storage definition in metadata file: it's a bug or result of manual intervention in metadata files #60349
00984_parser_stack_overflow Revert "Check stack size in Parser" #60216
test_replicated_database/test.py::test_startup_without_zk, test_replicated_table_attach/test.py::test_startup_with_small_bg_pool_partitioned Revert "Do not retry queries if container is down in integration tests" #60215
AST Fuzzer (ubsan) Logical error: 'Expected single dictionary argument for function.'. (Analyzer) #58979
Upgrade Check (asan) ~~still figuring out, what happened there.~~ This failure is not unique to this PR Strange deadlock in sanitizerDeathCallback #60405

* Backport #59626 to 24.1: Fix_kql_issue_found_by_wingfuzz * Fix build --------- Co-authored-by: robot-clickhouse <[email protected]> Co-authored-by: János Benjamin Antal <[email protected]>

* Backport #59626 to 23.11: Fix_kql_issue_found_by_wingfuzz * Fix build --------- Co-authored-by: robot-clickhouse <[email protected]> Co-authored-by: János Benjamin Antal <[email protected]>

* Backport #59626 to 23.12: Fix_kql_issue_found_by_wingfuzz * Fix build --------- Co-authored-by: robot-clickhouse <[email protected]> Co-authored-by: János Benjamin Antal <[email protected]>

Fix_kql_issue_found_by_wingfuzz

84f09d0

This commit fix the issues: ClickHouse#59036 ClickHouse#59037 both issues are same reason, the input query exceed the max_query_size, so the condition isEnd() of token is not meet and cause the assertion failure

antaljanosbenjamin self-assigned this Feb 6, 2024

antaljanosbenjamin added the can be tested Allows running workflows for external contributors label Feb 6, 2024

robot-ch-test-poll4 added the pr-bugfix Pull request with bugfix, not backported by default label Feb 6, 2024

antaljanosbenjamin reviewed Feb 6, 2024

View reviewed changes

src/Parsers/Kusto/ParserKQLQuery.cpp Outdated Show resolved Hide resolved

fix_kql_issue_found_by_wingfuzz: use isValid instead of TokenType::En…

87bd9ae

…dOfStream

kothiga mentioned this pull request Feb 6, 2024

Fix KQL and PRQL distributed tables queries #59674

Closed

fix_kql_issue_found_by_wingfuzz: make functional test result consist

7c6e642

kashwy added 2 commits February 11, 2024 09:31

fix_kql_issue_found_by_wingfuzz: update test case for makeseries

f429ab0

fix_kql_issue_found_by_wingfuzz: disable makeseries

b35590f

alexey-milovidov reviewed Feb 13, 2024

View reviewed changes

Merge remote-tracking branch 'origin/master' into fix_kql_issue_found…

69b9547

…_by_wingfuzz

antaljanosbenjamin merged commit 795c1a9 into ClickHouse:master Feb 26, 2024
238 of 273 checks passed

robot-clickhouse added the pr-synced-to-cloud The PR is synced to the cloud repo label Feb 26, 2024

antaljanosbenjamin added v23.11-must-backport pr-must-backport-cloud labels Feb 26, 2024

This was referenced Feb 26, 2024

Cherry pick #59626 to 23.11: Fix_kql_issue_found_by_wingfuzz #60410

Merged

Cherry pick #59626 to 23.12: Fix_kql_issue_found_by_wingfuzz #60411

Merged

Cherry pick #59626 to 24.1: Fix_kql_issue_found_by_wingfuzz #60412

Merged

robot-clickhouse added a commit that referenced this pull request Feb 26, 2024

Backport #59626 to 24.1: Fix_kql_issue_found_by_wingfuzz

a0e283f

robot-clickhouse-ci-2 mentioned this pull request Feb 26, 2024

Backport #59626 to 24.1: Fix_kql_issue_found_by_wingfuzz #60413

Merged

robot-clickhouse added a commit that referenced this pull request Feb 26, 2024

Backport #59626 to 23.11: Fix_kql_issue_found_by_wingfuzz

7723e31

robot-ch-test-poll4 mentioned this pull request Feb 26, 2024

Backport #59626 to 23.11: Fix_kql_issue_found_by_wingfuzz #60416

Merged

robot-clickhouse added a commit that referenced this pull request Feb 26, 2024

Backport #59626 to 23.12: Fix_kql_issue_found_by_wingfuzz

3a5a2d3

robot-ch-test-poll4 mentioned this pull request Feb 26, 2024

Backport #59626 to 23.12: Fix_kql_issue_found_by_wingfuzz #60417

Merged

robot-ch-test-poll4 added pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore pr-backports-created-cloud labels Feb 26, 2024

alexey-milovidov mentioned this pull request Feb 27, 2024

Merging #59674. #60470

Merged

kashwy mentioned this pull request Feb 29, 2024

Fix_max_query_size_for_kql_compound_operator: #60534

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix_kql_issue_found_by_wingfuzz #59626

Fix_kql_issue_found_by_wingfuzz #59626

kashwy commented Feb 6, 2024 •

edited by antaljanosbenjamin

Loading

robot-ch-test-poll4 commented Feb 6, 2024 •

edited

Loading

antaljanosbenjamin left a comment

antaljanosbenjamin commented Feb 6, 2024

kashwy commented Feb 6, 2024

yakov-olkhovskiy commented Feb 6, 2024 •

edited

Loading

kashwy commented Feb 6, 2024 •

edited

Loading

kashwy commented Feb 7, 2024 •

edited

Loading

antaljanosbenjamin commented Feb 8, 2024

kashwy commented Feb 11, 2024

kashwy commented Feb 12, 2024

kashwy commented Feb 13, 2024

alexey-milovidov Feb 13, 2024

kashwy Feb 13, 2024 •

edited

Loading

alexey-milovidov Feb 13, 2024

kashwy Feb 13, 2024

antaljanosbenjamin Feb 14, 2024

alexey-milovidov commented Feb 15, 2024

antaljanosbenjamin commented Feb 15, 2024

antaljanosbenjamin commented Feb 15, 2024

kashwy commented Feb 15, 2024 •

edited

Loading

kashwy commented Feb 15, 2024

antaljanosbenjamin commented Feb 15, 2024

kashwy commented Feb 15, 2024

antaljanosbenjamin commented Feb 15, 2024

kashwy commented Feb 15, 2024

kashwy commented Feb 22, 2024

antaljanosbenjamin commented Feb 22, 2024

kashwy commented Feb 22, 2024

antaljanosbenjamin commented Feb 26, 2024 •

edited

Loading

		@@ -373,9 +373,9 @@ bool ParserKQLQuery::parseImpl(Pos & pos, ASTPtr & node, Expected & expected)

		uint16_t bracket_count = 0;

		while ((pos->type < TokenType::EndOfStream \|\|

Fix_kql_issue_found_by_wingfuzz #59626

Fix_kql_issue_found_by_wingfuzz #59626

Conversation

kashwy commented Feb 6, 2024 • edited by antaljanosbenjamin Loading

Changelog category (leave one):

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

robot-ch-test-poll4 commented Feb 6, 2024 • edited Loading

antaljanosbenjamin left a comment

Choose a reason for hiding this comment

antaljanosbenjamin commented Feb 6, 2024

kashwy commented Feb 6, 2024

yakov-olkhovskiy commented Feb 6, 2024 • edited Loading

kashwy commented Feb 6, 2024 • edited Loading

kashwy commented Feb 7, 2024 • edited Loading

antaljanosbenjamin commented Feb 8, 2024

kashwy commented Feb 11, 2024

kashwy commented Feb 12, 2024

kashwy commented Feb 13, 2024

alexey-milovidov Feb 13, 2024

Choose a reason for hiding this comment

kashwy Feb 13, 2024 • edited Loading

Choose a reason for hiding this comment

alexey-milovidov Feb 13, 2024

Choose a reason for hiding this comment

kashwy Feb 13, 2024

Choose a reason for hiding this comment

antaljanosbenjamin Feb 14, 2024

Choose a reason for hiding this comment

alexey-milovidov commented Feb 15, 2024

antaljanosbenjamin commented Feb 15, 2024

antaljanosbenjamin commented Feb 15, 2024

kashwy commented Feb 15, 2024 • edited Loading

kashwy commented Feb 15, 2024

antaljanosbenjamin commented Feb 15, 2024

kashwy commented Feb 15, 2024

antaljanosbenjamin commented Feb 15, 2024

kashwy commented Feb 15, 2024

kashwy commented Feb 22, 2024

antaljanosbenjamin commented Feb 22, 2024

kashwy commented Feb 22, 2024

antaljanosbenjamin commented Feb 26, 2024 • edited Loading

kashwy commented Feb 6, 2024 •

edited by antaljanosbenjamin

Loading

robot-ch-test-poll4 commented Feb 6, 2024 •

edited

Loading

yakov-olkhovskiy commented Feb 6, 2024 •

edited

Loading

kashwy commented Feb 6, 2024 •

edited

Loading

kashwy commented Feb 7, 2024 •

edited

Loading

kashwy Feb 13, 2024 •

edited

Loading

kashwy commented Feb 15, 2024 •

edited

Loading

antaljanosbenjamin commented Feb 26, 2024 •

edited

Loading