Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add settings allow_suspicious_fixed_string_types #41495

Merged
merged 3 commits into from
Sep 21, 2022
Merged

Add settings allow_suspicious_fixed_string_types #41495

merged 3 commits into from
Sep 21, 2022

Conversation

canhld94
Copy link
Contributor

Changelog category (leave one):

  • Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

  • Add settings allow_suspicious_fixed_string_types to prevent users from creating columns of type FixedString with size > 256

Close #41452

Information about CI checks: https://clickhouse.com/docs/en/development/continuous-integration/

@robot-clickhouse robot-clickhouse added the pr-improvement Pull request with some product improvements label Sep 19, 2022
@evillique evillique self-assigned this Sep 19, 2022
@alexey-milovidov alexey-milovidov added the can be tested Allows running workflows for external contributors label Sep 19, 2022
@canhld94
Copy link
Contributor Author

Integration tests failed on a keeper test; stress test OOM kill. Looks doesn't relate.

@evillique evillique merged commit 49e0a87 into ClickHouse:master Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evillique evillique evillique approved these changes

Assignees

@evillique evillique

Labels
can be tested Allows running workflows for external contributors pr-improvement Pull request with some product improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

A setting allow_suspicious_fixed_string_types
4 participants
@canhld94 @evillique @alexey-milovidov @robot-clickhouse