Fix incorrect directory remove in zero copy replication #40844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robot-ch-test-poll
added
the
pr-bugfix
tavplubix
reviewed
Aug 31, 2022
tavplubix
reviewed
Aug 31, 2022
tavplubix
approved these changes
Aug 31, 2022
|
Integration -- just timeout on start. |
azat
reviewed
Oct 25, 2022
| { | ||
| keep_shared = disk->supportZeroCopyReplication() && settings->allow_remote_fs_zero_copy_replication; | ||
| if (keep_shared) | ||
| LOG_WARNING(log, "Since zero-copy replication is enabled we are not going to remove blobs from shared storage for {}", full_path); |
There was a problem hiding this comment.
So it means that they will never be removed?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fix extremely rare bug which can lead to potential data loss in zero-copy replication.