Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specialize date time comparision. #27122

Merged
merged 1 commit into from
Aug 4, 2021

Conversation

amosbird
Copy link
Collaborator

@amosbird amosbird commented Aug 3, 2021

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Changelog category (leave one):

  • Performance Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Specialize date time related comparison to achieve better performance. This fixes #27083 .

Detailed description / Documentation draft:
.

@robot-clickhouse robot-clickhouse added the pr-performance Pull request with some performance improvements label Aug 3, 2021
@amosbird
Copy link
Collaborator Author

amosbird commented Aug 3, 2021

The test failure makes me wonder... It relates to FunctionsConversion, but mine is FunctionsComparison

Copy link
Member

@CurtizJ CurtizJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CurtizJ
Copy link
Member

CurtizJ commented Aug 4, 2021

The test failure is related to enabling random timezones in functional tests. #27193.

@CurtizJ CurtizJ merged commit 2b6dc35 into ClickHouse:master Aug 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-performance Pull request with some performance improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DateTime and Date slower comparation than DateTime and (Int32,String,DateTime)
3 participants