Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable async_socket_for_remote #23683

Merged
merged 1 commit into from
Apr 28, 2021
Merged

Conversation

KochetovNicolai
Copy link
Member

@KochetovNicolai KochetovNicolai commented Apr 27, 2021

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Changelog category (leave one):

  • Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Enable async_socket_for_remote by default.

After #23309, #21167 (comment)

@robot-clickhouse robot-clickhouse added pr-bugfix Pull request with bugfix, not backported by default pr-improvement Pull request with some product improvements and removed pr-bugfix Pull request with bugfix, not backported by default labels Apr 27, 2021
@alexey-milovidov
Copy link
Member

@KochetovNicolai I changed to "Improvement", is it Ok?

@alexey-milovidov alexey-milovidov self-assigned this Apr 28, 2021
@KochetovNicolai
Copy link
Member Author

I changed to "Improvement", is it Ok?

Ok. Do we want to keep it disabled for current releases?

@KochetovNicolai KochetovNicolai merged commit 1812737 into master Apr 28, 2021
@KochetovNicolai KochetovNicolai deleted the enable_async_socket_for_remote branch April 28, 2021 09:29
@alexey-milovidov
Copy link
Member

I'm Ok enabling in 21.5, not Ok enabling in previous releases.

KochetovNicolai added a commit that referenced this pull request Apr 28, 2021
Enable async_socket_for_remote

(cherry picked from commit 1812737)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-improvement Pull request with some product improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants