Correct sample_block in HashJoin for dict join with join_algorithm

[vdimir]

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Changelog category (leave one):

• Bug Fix

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

• Fix bug in dict join with join_algorithm = 'auto'. Close (JOIN with dictionary) HashJoin: container overflow (range check) #23002

[vdimir]

We got error because with join_algorithm = auto we save key column into sample_block

ClickHouse/src/Interpreters/HashJoin.cpp

Lines 573 to 575 in 71c27a4

	/// We could remove key columns for LEFT | INNER HashJoin but we should keep them for JoinSwitcher (if any).
	bool save_key_columns = !table_join->forceHashJoin() || isRightOrFull(kind);
	if (save_key_columns)

But dictionary_reader always uses HashJoin and return block without it.

So, it leads to wrong indices

ClickHouse/src/Interpreters/HashJoin.cpp

Line 721 in 71c27a4

right_indexes.push_back(saved_block_sample.getPositionByName(tn.second));

and out of bound error

ClickHouse/src/Interpreters/HashJoin.cpp

Line 738 in 71c27a4

columns[j]->insertFrom(*block.getByPosition(right_indexes[j]).column, row_num);

[alexey-milovidov]

The fix looks alright.

[alexey-milovidov]

@kitaisreal said that you are planning to implement a different fix.
But this is already good enough to merge. Let's merge it and then change to a different solution.