Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ppc64le: Fix compiling boost #22474

Merged

Conversation

mastertheknife
Copy link
Contributor

@mastertheknife mastertheknife commented Apr 1, 2021

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Changelog category (leave one):

  • Build/Testing/Packaging Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fix compiling boost on ppc64le
...

Detailed description / Documentation draft:

  1. Added support for ppc64le
  2. Fixed errors about undefined symbols such as jump_fcontext when compiling with sanitizer enabled. This is because jump_fcontext is referenced by some files, such as boost/context/execution_context_v2.hpp
    Those functions exist in the asm files, so these asm files should be compiled at all times.
ld.lld: error: undefined symbol: make_fcontext
>>> referenced by fiber_fcontext.hpp:171 (../contrib/boost/boost/context/fiber_fcontext.hpp:171)
>>>               RemoteQueryExecutorReadContext.cpp.o:(void* boost::context::detail::create_fiber1<boost::context::detail::fiber_record<boost::context::fiber, FiberStack&, DB::RemoteQueryExecutorRoutine>, FiberStack&, DB::RemoteQueryExecutorRoutine>(FiberStack&, DB::RemoteQueryExecutorRoutine&&)) in archive src/libdbms.a
collect2: error: ld returned 1 exit status

...

@robot-clickhouse robot-clickhouse added the pr-build Pull request with build/testing/packaging improvement label Apr 1, 2021
@robot-clickhouse robot-clickhouse added the submodule changed At least one submodule changed in this PR. label Apr 1, 2021
@alexey-milovidov alexey-milovidov self-assigned this Apr 1, 2021
@alexey-milovidov alexey-milovidov merged commit 172835e into ClickHouse:master Apr 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-build Pull request with build/testing/packaging improvement submodule changed At least one submodule changed in this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants