Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve do_not_merge_across_partitions_select_final optimization. #19375

Merged
merged 9 commits into from
Feb 1, 2021

Conversation

Avogar
Copy link
Member

@Avogar Avogar commented Jan 21, 2021

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Changelog category (leave one):

  • Performance Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Add parallel select final for one part with level>0 when do_not_merge_across_partitions_select_final setting is 1.

Relates: #15938 and #11722

@robot-clickhouse robot-clickhouse added the pr-performance Pull request with some performance improvements label Jan 21, 2021
@Avogar Avogar mentioned this pull request Jan 21, 2021
@alexey-milovidov alexey-milovidov self-assigned this Jan 21, 2021
@azat
Copy link
Collaborator

azat commented Jan 24, 2021

AST fuzzer (UBSan) — ../src/Functions/FunctionDateOrDateTimeAddInterval.h:92:26: runtime error: signed integer overflow: -9223372036854775807 * 60 cannot be repr

#19466

@Avogar
Copy link
Member Author

Avogar commented Jan 29, 2021

If I understand correctly, then length(thread_ids) > 1 is not correct, because there will be threads at least for:

Yes, you are right, I didn't think about it, thanks.

@Avogar
Copy link
Member Author

Avogar commented Feb 1, 2021

@alexey-milovidov All checks passed, can I merge it?

@alexey-milovidov
Copy link
Member

Yes, sure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-must-backport Pull request should be backported intentionally. Use this label with great care! pr-performance Pull request with some performance improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants