-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve do_not_merge_across_partitions_select_final optimization. #19375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robot-clickhouse
added
the
pr-performance
Pull request with some performance improvements
label
Jan 21, 2021
Merged
alexey-milovidov
approved these changes
Jan 21, 2021
azat
reviewed
Jan 24, 2021
tests/queries/0_stateless/01524_do_not_merge_across_partitions_select_final.sql
Outdated
Show resolved
Hide resolved
|
azat
reviewed
Jan 24, 2021
azat
reviewed
Jan 24, 2021
azat
reviewed
Jan 24, 2021
Yes, you are right, I didn't think about it, thanks. |
@alexey-milovidov All checks passed, can I merge it? |
Yes, sure. |
Avogar
added
the
pr-must-backport
Pull request should be backported intentionally. Use this label with great care!
label
Apr 27, 2021
1 task
20 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
pr-must-backport
Pull request should be backported intentionally. Use this label with great care!
pr-performance
Pull request with some performance improvements
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Add parallel select final for one part with level>0 when
do_not_merge_across_partitions_select_final
setting is 1.Relates: #15938 and #11722