-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docker: fix uid/gid of the clickhouse user #19096
Merged
alexey-milovidov
merged 3 commits into
ClickHouse:master
from
filimonov:docker_fix_uid_gid
Jan 15, 2021
Merged
Docker: fix uid/gid of the clickhouse user #19096
alexey-milovidov
merged 3 commits into
ClickHouse:master
from
filimonov:docker_fix_uid_gid
Jan 15, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Explicitly set uid / gid of clickhouse user & group to the fixed values 101. It is especially important for rootless containers: in that case entrypoint can't do chown and owners of mounted volumes should be configured externally. We do that in advance at the begining of Dockerfile before any packages will be installed to prevent picking those uid / gid by some unrelated software. The same uid / gid (101) is used both for alpine and ubuntu. Number 101 is used by default in openshift, and was used by all clickhouse-server docker images before 20.10. In 20.11 it was changed (by accident) to 999.
robot-clickhouse
added
the
pr-improvement
Pull request with some product improvements
label
Jan 14, 2021
This was referenced Jan 14, 2021
alexey-milovidov
added
the
pr-must-backport
Pull request should be backported intentionally. Use this label with great care!
label
Jan 15, 2021
alexey-milovidov
approved these changes
Jan 15, 2021
This was referenced Jan 15, 2021
robot-clickhouse
pushed a commit
that referenced
this pull request
Jan 15, 2021
robot-clickhouse
pushed a commit
that referenced
this pull request
Jan 15, 2021
robot-clickhouse
pushed a commit
that referenced
this pull request
Jan 15, 2021
alexey-milovidov
added a commit
that referenced
this pull request
Jan 16, 2021
Backport #19096 to 21.1: Docker: fix uid/gid of the clickhouse user
alexey-milovidov
added a commit
that referenced
this pull request
Jan 16, 2021
Backport #19096 to 20.11: Docker: fix uid/gid of the clickhouse user
alexey-milovidov
added a commit
that referenced
this pull request
Jan 16, 2021
Backport #19096 to 20.12: Docker: fix uid/gid of the clickhouse user
This was referenced Jan 20, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
pr-improvement
Pull request with some product improvements
pr-must-backport
Pull request should be backported intentionally. Use this label with great care!
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Explicitly set uid / gid of clickhouse user & group to the fixed values (101) in clickhouse-server images.
Detailed description / Documentation draft:
Explicitly set uid / gid of clickhouse user & group to the fixed values 101.
It is especially important for rootless containers: in that case entrypoint can't do chown and owners of mounted volumes should be configured externally.
We do that in advance at the begining of Dockerfile before any packages will be installed to prevent picking those uid / gid by some unrelated software.
The same uid / gid (101) is used both for alpine and ubuntu.
Number 101 is used by default in openshift, and was used by all clickhouse-server docker images <= 20.10. In 20.11 it was changed (by accident) to 999.
PS. IMHO should be backported to >= 20.11.