Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker: fix uid/gid of the clickhouse user #19096

Merged
merged 3 commits into from
Jan 15, 2021

Conversation

filimonov
Copy link
Contributor

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Changelog category (leave one):

  • Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Explicitly set uid / gid of clickhouse user & group to the fixed values (101) in clickhouse-server images.

Detailed description / Documentation draft:

Explicitly set uid / gid of clickhouse user & group to the fixed values 101.

It is especially important for rootless containers: in that case entrypoint can't do chown and owners of mounted volumes should be configured externally.

We do that in advance at the begining of Dockerfile before any packages will be installed to prevent picking those uid / gid by some unrelated software.

The same uid / gid (101) is used both for alpine and ubuntu.

Number 101 is used by default in openshift, and was used by all clickhouse-server docker images <= 20.10. In 20.11 it was changed (by accident) to 999.

PS. IMHO should be backported to >= 20.11.

Explicitly set uid / gid of clickhouse user & group to the fixed values 101.

It is especially important for rootless containers: in that case entrypoint can't do chown
and owners of mounted volumes should be configured externally.

We do that in advance at the begining of Dockerfile before any packages will be installed
to prevent picking those uid / gid by some unrelated software.

The same uid / gid (101) is used both for alpine and ubuntu.

Number 101 is used by default in openshift, and was used by all clickhouse-server docker images
before 20.10. In 20.11 it was changed (by accident) to 999.
@robot-clickhouse robot-clickhouse added the pr-improvement Pull request with some product improvements label Jan 14, 2021
@alexey-milovidov alexey-milovidov self-assigned this Jan 15, 2021
@alexey-milovidov alexey-milovidov added the pr-must-backport Pull request should be backported intentionally. Use this label with great care! label Jan 15, 2021
@alexey-milovidov alexey-milovidov merged commit 6689f6e into ClickHouse:master Jan 15, 2021
alexey-milovidov added a commit that referenced this pull request Jan 16, 2021
Backport #19096 to 21.1: Docker: fix uid/gid of the clickhouse user
alexey-milovidov added a commit that referenced this pull request Jan 16, 2021
Backport #19096 to 20.11: Docker: fix uid/gid of the clickhouse user
alexey-milovidov added a commit that referenced this pull request Jan 16, 2021
Backport #19096 to 20.12: Docker: fix uid/gid of the clickhouse user
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-improvement Pull request with some product improvements pr-must-backport Pull request should be backported intentionally. Use this label with great care!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants