Add a check to avoid exception when long alias equals to column #18968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robot-clickhouse
added
the
pr-bugfix
mathfool
changed the title
abyss7
approved these changes
Jan 20, 2021
| auto alias = aliases.find(ident->name())->second; | ||
| auto alias_table = IdentifierSemantic::getTableName(alias->ptr()); | ||
| bool alias_equals_column_name = false; | ||
| if ((!ident->isShort() && alias->ptr()->getColumnNameWithoutAlias() == ident->getColumnNameWithoutAlias()) |
There was a problem hiding this comment.
!ident->isShort() is already checked in the outer condition.
This was referenced Jan 20, 2021
Merged
Merged
Merged
robot-clickhouse
pushed a commit
that referenced
this pull request
Jan 20, 2021
…ias equals to column
robot-clickhouse
pushed a commit
that referenced
this pull request
Jan 20, 2021
…as equals to column
robot-clickhouse
pushed a commit
that referenced
this pull request
Jan 20, 2021
…ias equals to column
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
to fix #18894
Add a check to avoid exception when long column alias('table.column' style, usually auto-generated by BI tools like Looker) equals to long table name.
Detailed description / Documentation draft:
TODO: