Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix access rights for SELECT count() #18233

Merged

Conversation

vitlibar
Copy link
Member

@vitlibar vitlibar commented Dec 18, 2020

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Changelog category:

  • Bug Fix

Changelog entry:
SELECT count() FROM table now can be executed if only one any column can be selected from the table.
This PR fixes #10639

@robot-clickhouse robot-clickhouse added the pr-bugfix Pull request with bugfix, not backported by default label Dec 18, 2020
@vitlibar vitlibar marked this pull request as draft December 18, 2020 20:13
@vitlibar vitlibar force-pushed the fix-access-rights-for-select-count branch 6 times, most recently from e26270a to e21b25b Compare December 27, 2020 18:15
@vitlibar vitlibar changed the title [WIP] Fix access rights for SELECT count() Fix access rights for SELECT count() Dec 30, 2020
@vitlibar vitlibar marked this pull request as ready for review December 30, 2020 11:42
@vitlibar vitlibar force-pushed the fix-access-rights-for-select-count branch from e21b25b to 235ea22 Compare December 30, 2020 12:00
@alexey-milovidov alexey-milovidov self-assigned this Jan 16, 2021
@alexey-milovidov alexey-milovidov merged commit d2366b5 into ClickHouse:master Jan 16, 2021
alexey-milovidov added a commit that referenced this pull request Jan 17, 2021
Backport #18233 to 21.1: Fix access rights for SELECT count()
alexey-milovidov added a commit that referenced this pull request Jan 23, 2021
Backport #18233 to 20.12: Fix access rights for SELECT count()
vitlibar pushed a commit that referenced this pull request Jan 26, 2021
…count

Fix access rights for SELECT count()

(cherry picked from commit d2366b5)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-bugfix Pull request with bugfix, not backported by default
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RBAC: SELECT count() FROM table may not work if user has no access to some column.
3 participants