Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix multiline queries with comments in interactive mode #17565

Merged
merged 2 commits into from
Nov 30, 2020

Conversation

alexey-milovidov
Copy link
Member

Changelog category (leave one):

  • Bug Fix

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
When clickhouse-client is used in interactive mode with multiline queries, single line comment was erronously extended till the end of query. This fixes #13654.

@robot-clickhouse robot-clickhouse added the pr-bugfix Pull request with bugfix, not backported by default label Nov 29, 2020
@alexey-milovidov alexey-milovidov self-assigned this Nov 30, 2020
@alexey-milovidov alexey-milovidov merged commit 46e685e into master Nov 30, 2020
@alexey-milovidov alexey-milovidov deleted the fix-multiline-queries-with-comments branch November 30, 2020 06:38
robot-clickhouse pushed a commit that referenced this pull request Nov 30, 2020
robot-clickhouse pushed a commit that referenced this pull request Nov 30, 2020
robot-clickhouse pushed a commit that referenced this pull request Nov 30, 2020
robot-clickhouse pushed a commit that referenced this pull request Nov 30, 2020
vitlibar pushed a commit that referenced this pull request Nov 30, 2020
Backport #17565 to 20.11: Fix multiline queries with comments in interactive mode
vitlibar pushed a commit that referenced this pull request Nov 30, 2020
Backport #17565 to 20.10: Fix multiline queries with comments in interactive mode
vitlibar pushed a commit that referenced this pull request Dec 1, 2020
Backport #17565 to 20.12: Fix multiline queries with comments in interactive mode
vitlibar pushed a commit that referenced this pull request Dec 1, 2020
Backport #17565 to 20.9: Fix multiline queries with comments in interactive mode
@alexey-milovidov
Copy link
Member Author

It breaked multiline history navigation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-bugfix Pull request with bugfix, not backported by default
Projects
None yet
Development

Successfully merging this pull request may close these issues.

client interactive mode line comments (-- ) does not work anymore.
2 participants