fix-3091 added simple mapping for constatnt expressions #382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is an automated comment for commit ef5abbf with description of existing statuses. It's updated for the latest CI running
|
kashwy
reviewed
Aug 11, 2023
kashwy
reviewed
Aug 11, 2023
| }, | ||
| { | ||
| "print A[B[1]]", | ||
| "SELECT A[if((B[if(1 >= 0, 1 + 1, 1)]) >= 0, (B[if(1 >= 0, 1 + 1, 1)]) + 1, B[if(1 >= 0, 1 + 1, 1)])] AS print_0" | ||
| "SELECT A[if((B[2]) >= 0, (B[2]) + 1, B[2])] AS print_0" |
There was a problem hiding this comment.
can this recursive case be solved too?
There was a problem hiding this comment.
We would need to get the value of B[2] to correctly map it, which isn't available during Parsing. Therefore, treating B[2] as an arbitrary expression.
There was a problem hiding this comment.
We would need to get the value of B[2] to correctly map it, which isn't available during Parsing. Therefore, treating B[2] as an arbitrary expression.
ok, that's good
kashwy
approved these changes
Aug 16, 2023
kashwy
pushed a commit
that referenced
this pull request
Sep 19, 2023
…382) * fix-3091 added simple mapping for constatnt expressions * fixed unit tests * added testcase for negetive array index
kothiga
pushed a commit
that referenced
this pull request
Dec 9, 2023
…382) * fix-3091 added simple mapping for constatnt expressions * fixed unit tests * added testcase for negetive array index
kothiga
pushed a commit
that referenced
this pull request
Jan 11, 2024
…382) * fix-3091 added simple mapping for constatnt expressions * fixed unit tests * added testcase for negetive array index
kothiga
pushed a commit
that referenced
this pull request
Mar 7, 2024
…382) * fix-3091 added simple mapping for constatnt expressions * fixed unit tests * added testcase for negetive array index
SuzyWangIBMer
pushed a commit
that referenced
this pull request
Apr 11, 2024
…382) * fix-3091 added simple mapping for constatnt expressions * fixed unit tests * added testcase for negetive array index
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: https://github.ibm.com/ClickHouse/issue-repo/issues/3091
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Requirement was to add a direct mapping without using expression inside the array. Therefore, now computing the index first and then passing it to CH SQL only for constant numerical expressions.
Query:
select * from kql(events | project custom_prop_value[0] | take 1)Output: