Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check for accepted values for accuracy in dcount,dcountif #375

Merged
merged 2 commits into from
Jul 31, 2023

Conversation

bhavnajindal
Copy link

Issue: https://github.ibm.com/ClickHouse/issue-repo/issues/2524

Changelog category (leave one):

  • Bug Fix (user-visible misbehavior in an official stable release)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Added exception handling to handle cases when the argument value provided for accuracy is not one of the accepted values (0,1,2,3,4)

Example use:

Query 1:
StormEvents | summarize dcount(EventType, -1);

Output

Exception on client:
Code: 36. DB::Exception: Argument 2 must be a constant integer with value 0, 1, 2, 3 or 4 (0 = fast , 1 = default, 2 = accurate, 3 = extra accurate, 4 = super accurate. (BAD_ARGUMENTS)

Query 2:
StormEvents | summarize dcountif(EventType, 8, x=10);

Output

Exception on client:
Code: 36. DB::Exception: Argument 2 must be a constant integer with value 0, 1, 2, 3 or 4 (0 = fast , 1 = default, 2 = accurate, 3 = extra accurate, 4 = super accurate. (BAD_ARGUMENTS)

@bhavnajindal bhavnajindal requested a review from ltrk2 July 18, 2023 18:02
Copy link
Member

@ltrk2 ltrk2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a functional test case to cover the functionality.

@bhavnajindal bhavnajindal requested a review from ltrk2 July 25, 2023 14:49
@bhavnajindal bhavnajindal merged commit 3c83bab into Kusto-phase3 Jul 31, 2023
12 of 15 checks passed
ltrk2 pushed a commit that referenced this pull request Aug 3, 2023
* check for accepted values for accuracy in dcount,dcountif

* Added functional Testacse and fixed the error msg
ltrk2 pushed a commit that referenced this pull request Aug 3, 2023
* check for accepted values for accuracy in dcount,dcountif

* Added functional Testacse and fixed the error msg
kashwy pushed a commit that referenced this pull request Sep 19, 2023
* check for accepted values for accuracy in dcount,dcountif

* Added functional Testacse and fixed the error msg
kothiga pushed a commit that referenced this pull request Dec 9, 2023
* check for accepted values for accuracy in dcount,dcountif

* Added functional Testacse and fixed the error msg
kothiga pushed a commit that referenced this pull request Jan 11, 2024
* check for accepted values for accuracy in dcount,dcountif

* Added functional Testacse and fixed the error msg
kothiga pushed a commit that referenced this pull request Mar 7, 2024
* check for accepted values for accuracy in dcount,dcountif

* Added functional Testacse and fixed the error msg
SuzyWangIBMer pushed a commit that referenced this pull request Apr 11, 2024
* check for accepted values for accuracy in dcount,dcountif

* Added functional Testacse and fixed the error msg
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants