forked from ClickHouse/ClickHouse
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
check for accepted values for accuracy in dcount,dcountif #375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ltrk2
approved these changes
Jul 24, 2023
ltrk2
requested changes
Jul 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a functional test case to cover the functionality.
ltrk2
approved these changes
Jul 28, 2023
ltrk2
pushed a commit
that referenced
this pull request
Aug 3, 2023
* check for accepted values for accuracy in dcount,dcountif * Added functional Testacse and fixed the error msg
ltrk2
pushed a commit
that referenced
this pull request
Aug 3, 2023
* check for accepted values for accuracy in dcount,dcountif * Added functional Testacse and fixed the error msg
kashwy
pushed a commit
that referenced
this pull request
Sep 19, 2023
* check for accepted values for accuracy in dcount,dcountif * Added functional Testacse and fixed the error msg
kothiga
pushed a commit
that referenced
this pull request
Dec 9, 2023
* check for accepted values for accuracy in dcount,dcountif * Added functional Testacse and fixed the error msg
kothiga
pushed a commit
that referenced
this pull request
Jan 11, 2024
* check for accepted values for accuracy in dcount,dcountif * Added functional Testacse and fixed the error msg
kothiga
pushed a commit
that referenced
this pull request
Mar 7, 2024
* check for accepted values for accuracy in dcount,dcountif * Added functional Testacse and fixed the error msg
SuzyWangIBMer
pushed a commit
that referenced
this pull request
Apr 11, 2024
* check for accepted values for accuracy in dcount,dcountif * Added functional Testacse and fixed the error msg
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: https://github.ibm.com/ClickHouse/issue-repo/issues/2524
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Added exception handling to handle cases when the argument value provided for accuracy is not one of the accepted values (0,1,2,3,4)
Example use:
Query 1:
StormEvents | summarize dcount(EventType, -1);
Output
Query 2:
StormEvents | summarize dcountif(EventType, 8, x=10);
Output