-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TKEDissipationVerticalDiffusivity (aka k-epsilon) turbulence closure (take 2) #3605
Conversation
OK! I'll review this! so in Oceananigans terms is the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good job; sprinkled few questions/comments here and there
...lence_closure_implementations/TKEBasedVerticalDiffusivities/TKEBasedVerticalDiffusivities.jl
Outdated
Show resolved
Hide resolved
...rbulence_closure_implementations/TKEBasedVerticalDiffusivities/catke_vertical_diffusivity.jl
Outdated
Show resolved
Hide resolved
...losure_implementations/TKEBasedVerticalDiffusivities/tke_dissipation_vertical_diffusivity.jl
Outdated
Show resolved
Hide resolved
...losure_implementations/TKEBasedVerticalDiffusivities/tke_dissipation_vertical_diffusivity.jl
Outdated
Show resolved
Hide resolved
...losure_implementations/TKEBasedVerticalDiffusivities/tke_dissipation_vertical_diffusivity.jl
Outdated
Show resolved
Hide resolved
...urbulence_closure_implementations/TKEBasedVerticalDiffusivities/tke_dissipation_equations.jl
Outdated
Show resolved
Hide resolved
...urbulence_closure_implementations/TKEBasedVerticalDiffusivities/tke_dissipation_equations.jl
Outdated
Show resolved
Hide resolved
...urbulence_closure_implementations/TKEBasedVerticalDiffusivities/tke_dissipation_equations.jl
Outdated
Show resolved
Hide resolved
...closure_implementations/TKEBasedVerticalDiffusivities/tke_dissipation_stability_functions.jl
Show resolved
Hide resolved
...losure_implementations/TKEBasedVerticalDiffusivities/tke_dissipation_vertical_diffusivity.jl
Outdated
Show resolved
Hide resolved
...lence_closure_implementations/TKEBasedVerticalDiffusivities/TKEBasedVerticalDiffusivities.jl
Outdated
Show resolved
Hide resolved
Co-authored-by: Simone Silvestri <[email protected]>
…asedVerticalDiffusivities/catke_vertical_diffusivity.jl Co-authored-by: Navid C. Constantinou <[email protected]>
…asedVerticalDiffusivities/tke_dissipation_equations.jl Co-authored-by: Navid C. Constantinou <[email protected]>
…asedVerticalDiffusivities/tke_dissipation_vertical_diffusivity.jl Co-authored-by: Navid C. Constantinou <[email protected]>
I think we should call it "TKE dissipation vertical diffusivity", or k-epsilon in a nod to the literature. I don't think we shoudl call it "e-epsilon". |
No, definitely not!! I wasn't implying that we call it "e-epsilon". I was just trying to see whether the Let's call it "TKE dissipation vertical diffusivity" but let's also mention in the docstring or somewhere that this is "the otherwise known as k-epsilon" |
Ah yes, "k" is turbulent kinetic energy in the name "k-epsilon". |
* Bump to 0.91.3 Captures #3605 * Bump down * Bump up
This PR replaces #3509. Also, it builds off #3585 which hopefully we can merge soon so we don't enter merge conflict hell.
In short this PR implements k-epsilon. Although, the version that's implemented now is not by-the-book k-epsilon but rather a simplified version. I'd like to merge this PR basically as is and hopefully continue to work on it in the future.
There are some numerical considerations which should be reviewed and documented I think. First of all is the challenge of specifying a minimum tke, minimum dissipation rate, and also a maximum dissipation rate. These are useful for producing smooth diffusivities, which note are
But then there are challenges with implementing the TKE and dissipation equations. Because depending on the term, one may either want to impose or not impose these constraints.
It could be useful to try to get some lessons from other codes too.
It's not ready for production use, but at least it's doing reasonable things...