Enforce total buoyancy flux BC in tilted geometry example #3581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This example includes no explicit modification to the BCs on buoyancy, meaning that it defaults to a no-flux BC (or `FluxBoundaryCondition()`) on buoyancy. Following equation (6) of Wenegrat and Thomas (2020), we instead enforce a no-normal diffusive flux boundary condition on the *total* buoyancy, i.e. the perturbation plus the constantly-stratified `BackgroundField`. Because Oceananigans.jl does not allow diffusion to act on `BackgroundField`s, the background part of the no-flux BC is missing. However, we here can enforce it by specifying a perturbation flux BC that matches the implied background flux. Other minor changes: - Added equally-spaced buoyancy surfaces to movie panels - Guess timestep by minimum of advective and diffusive timescales, instead of just the advective timescale
glwagner
reviewed
May 5, 2024
glwagner
reviewed
May 5, 2024
Co-authored-by: Gregory L. Wagner <[email protected]>
glwagner
reviewed
May 5, 2024
added 3 commits
May 5, 2024 16:36
glwagner
reviewed
May 6, 2024
glwagner
reviewed
May 6, 2024
glwagner
reviewed
May 6, 2024
glwagner
approved these changes
May 6, 2024
Co-authored-by: Gregory L. Wagner <[email protected]>
Co-authored-by: Gregory L. Wagner <[email protected]>
|
LGTM, thanks for reviewing @glwagner |
|
I'll try to figure out what's going on with the distributed tests |
glwagner
reviewed
May 6, 2024
glwagner
reviewed
May 6, 2024
Co-authored-by: Gregory L. Wagner <[email protected]>
Co-authored-by: Gregory L. Wagner <[email protected]>
|
Nice work @hdrake ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This example includes no explicit modification to the BCs on buoyancy, meaning that it defaults to a no-flux BC (or
FluxBoundaryCondition()) on buoyancy.Following equation (6) of Wenegrat and Thomas (2020), we instead enforce a no-normal diffusive flux boundary condition on the total buoyancy, i.e. the perturbation plus the constantly-stratified
BackgroundField. Because Oceananigans.jl does not allow diffusion to act onBackgroundFields, the background part of the no-flux BC is missing. However, we here can enforce it by specifying a perturbation flux BC that matches the implied background flux.Other minor changes:
This addresses the problem with the
tilted_bottom_boundary_layer.jlexample identified by @liuchihl and noted in #3568. Recommend closing that issue but perhaps continuing some of the discussion in a "Discussion" post.