qsat depends on T not snow presence #805
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
We had set q_sfc = q_sat(T, ice) if snow was on the ground, and q_sfc = q_sat(T, liq) if not. If the snow variable is incorrect (due to incorrect forcing or otherwise), this could mean very cold land would have a higher q_sfc (over liq).
To-do
Run in AMIP, Coupler PR CliMA/ClimaCoupler.jl#976
Update unit tests to reflect change as needed
Content
change q_sfc function